Add 'isDir' to FileSystemEvent.

Add 'isDir' to FileSystemEvent.

BUG=https://code.google.com/p/dart/issues/detail?id=14425
R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29371

[Bill Hesse, 2013-10-28 16:30:13]

https://codereview.chromium.org/48613002/diff/40001/runtime/bin/file_patch.dart
File runtime/bin/file_patch.dart (right):

https://codereview.chromium.org/48613002/diff/40001/runtime/bin/file_patch.da...
runtime/bin/file_patch.dart:96: FileSystemEntityType.DIRECTORY;
This is exactly static FileSystemEntity.isDirectory(path).

https://codereview.chromium.org/48613002/diff/40001/sdk/lib/io/file_system_en...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/48613002/diff/40001/sdk/lib/io/file_system_en...
sdk/lib/io/file_system_entity.dart:677: final bool isDir;
I don't like isDir for the name of the property.  I would prefer isDirectory.

We don't use Dir in our API anywhere else - always Directory.

https://codereview.chromium.org/48613002/diff/40001/tests/standalone/io/file_...
File tests/standalone/io/file_system_watcher_test.dart (right):

https://codereview.chromium.org/48613002/diff/40001/tests/standalone/io/file_...
tests/standalone/io/file_system_watcher_test.dart:23:
Expect.isFalse(event.isDir);
Will there be a test where isDir is true?  There should be.

[Anders Johnsen, 2013-10-28 16:43:14]

PTAL

https://codereview.chromium.org/48613002/diff/40001/runtime/bin/file_patch.dart
File runtime/bin/file_patch.dart (right):

https://codereview.chromium.org/48613002/diff/40001/runtime/bin/file_patch.da...
runtime/bin/file_patch.dart:96: FileSystemEntityType.DIRECTORY;
On 2013/10/28 16:30:13, Bill Hesse wrote:
> This is exactly static FileSystemEntity.isDirectory(path).

Done.

https://codereview.chromium.org/48613002/diff/40001/sdk/lib/io/file_system_en...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/48613002/diff/40001/sdk/lib/io/file_system_en...
sdk/lib/io/file_system_entity.dart:677: final bool isDir;
On 2013/10/28 16:30:13, Bill Hesse wrote:
> I don't like isDir for the name of the property.  I would prefer isDirectory.
> 
> We don't use Dir in our API anywhere else - always Directory.

Done.

https://codereview.chromium.org/48613002/diff/40001/tests/standalone/io/file_...
File tests/standalone/io/file_system_watcher_test.dart (right):

https://codereview.chromium.org/48613002/diff/40001/tests/standalone/io/file_...
tests/standalone/io/file_system_watcher_test.dart:23:
Expect.isFalse(event.isDir);
On 2013/10/28 16:30:13, Bill Hesse wrote:
> Will there be a test where isDir is true?  There should be.

Done.

[Bill Hesse, 2013-10-28 17:05:33]

LGTM.

https://codereview.chromium.org/48613002/diff/120001/runtime/bin/file_patch.dart
File runtime/bin/file_patch.dart (right):

https://codereview.chromium.org/48613002/diff/120001/runtime/bin/file_patch.d...
runtime/bin/file_patch.dart:129: getPath(pair[link]), isDir, path));
Indentation.

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
File tests/standalone/io/file_system_watcher_test.dart (right):

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
tests/standalone/io/file_system_watcher_test.dart:39: var dir2 = new
Directory(dir.path + '/dir');
I really think we should always use join(dir.path, 'dir'), not +.
Maybe 'subdir'?

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
tests/standalone/io/file_system_watcher_test.dart:58: dir2.createSync();
Why not just dir2.create?

[Anders Johnsen, 2013-10-28 17:14:41]

https://codereview.chromium.org/48613002/diff/120001/runtime/bin/file_patch.dart
File runtime/bin/file_patch.dart (right):

https://codereview.chromium.org/48613002/diff/120001/runtime/bin/file_patch.d...
runtime/bin/file_patch.dart:129: getPath(pair[link]), isDir, path));
On 2013/10/28 17:05:33, Bill Hesse wrote:
> Indentation.

Done.

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
File tests/standalone/io/file_system_watcher_test.dart (right):

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
tests/standalone/io/file_system_watcher_test.dart:39: var dir2 = new
Directory(dir.path + '/dir');
On 2013/10/28 17:05:33, Bill Hesse wrote:
> I really think we should always use join(dir.path, 'dir'), not +.
> Maybe 'subdir'?

Done.

https://codereview.chromium.org/48613002/diff/120001/tests/standalone/io/file...
tests/standalone/io/file_system_watcher_test.dart:58: dir2.createSync();
On 2013/10/28 17:05:33, Bill Hesse wrote:
> Why not just dir2.create?

It does not add anything either way for this tests, however it's nicer for
debugging to keep them as sync.

[Anders Johnsen, 2013-10-28 17:14:51]

Committed patchset #4 manually as r29371 (presubmit successful).