Add 'isDir' to FileSystemEvent.

tests/standalone/io/file_system_watcher_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:async";
 import "dart:io";
 
 import "package:async_helper/async_helper.dart";
 import "package:expect/expect.dart";
 
 
 void testWatchCreateFile() {
   var dir = Directory.systemTemp.createTempSync('dart_file_system_watcher');
   var file = new File(dir.path + '/file');
 
   var watcher = dir.watch();
 
   asyncStart();
   var sub;
   sub = watcher.listen((event) {
     if (event is FileSystemCreateEvent &&
         event.path.endsWith('file')) {
+      Expect.isFalse(event.isDirectory);
       asyncEnd();
       sub.cancel();
       dir.deleteSync(recursive: true);
     }
   }, onError: (e) {
     dir.deleteSync(recursive: true);
     throw e;
   });
 
   file.createSync();
 }
 
 
+void testWatchCreateDir() {
+  var dir = Directory.systemTemp.createTempSync('dart_file_system_watcher');
+  var dir2 = new Directory(dir.path + '/dir');

[Bill Hesse, 2013/10/28 17:05:33]

I really think we should always use join(dir.path, 'dir'), not +.
Maybe 'subdir'?

[Anders Johnsen, 2013/10/28 17:14:41]

Done.

+
+  var watcher = dir.watch();
+
+  asyncStart();
+  var sub;
+  sub = watcher.listen((event) {
+    if (event is FileSystemCreateEvent &&
+        event.path.endsWith('dir')) {
+      Expect.isTrue(event.isDirectory);
+      asyncEnd();
+      sub.cancel();
+      dir.deleteSync(recursive: true);
+    }
+  }, onError: (e) {
+    dir.deleteSync(recursive: true);
+    throw e;
+  });
+
+  dir2.createSync();

[Bill Hesse, 2013/10/28 17:05:33]

Why not just dir2.create?

[Anders Johnsen, 2013/10/28 17:14:41]

It does not add anything either way for this tests, however it's nicer for
debugging to keep them as sync.

+}
+
+
 void testWatchModifyFile() {
   var dir = Directory.systemTemp.createTempSync('dart_file_system_watcher');
   var file = new File(dir.path + '/file');
   file.createSync();
 
   var watcher = dir.watch();
 
   asyncStart();
   var sub;
   sub = watcher.listen((event) {
@@ skipping 220 matching lines @@
     }, onError: (e) {
       asyncEnd();
       Expect.isTrue(e is FileSystemException);
     });
 }
 
 
 void main() {
   if (!FileSystemEntity.isWatchSupported) return;
   testWatchCreateFile();
+  testWatchCreateDir();
   testWatchModifyFile();
   testWatchMoveFile();
   testWatchDeleteFile();
   testWatchDeleteDir();
   testWatchOnlyModifyFile();
   testMultipleEvents();
   testWatchNonRecursive();
   testWatchNonExisting();
 }