Remove deprecated parts of dart:async.

Remove deprecated parts of dart:async.

Attempt to fix most uses of the deprecated features.

R=floitsch@google.com, nweiz@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29628

[Lasse Reichstein Nielsen, 2013-10-28 10:24:48]

Not all tests running, but almost (tools/test.py with no arguments has only one
error, in scheduled_test/nested_task_test).

Two errors in 'pub'. At least one is due to barback still having a
getAttachedStackTrace call.

[kevmoo-old, 2013-10-28 14:50:04]

https://codereview.chromium.org/48483002/diff/1/pkg/unittest/lib/src/test_cas...
File pkg/unittest/lib/src/test_case.dart (right):

https://codereview.chromium.org/48483002/diff/1/pkg/unittest/lib/src/test_cas...
pkg/unittest/lib/src/test_case.dart:75: if (stack == null && e is Error) {
You read my mind. I'm closing out https://codereview.chromium.org/45913002/

Thanks.

[Bob Nystrom, 2013-10-28 16:21:24]

scheduled_test, unittest, and apidoc LGTM.

[floitsch, 2013-10-28 22:55:29]

LGTM.
just minor comments.

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart#newco...
sdk/lib/async/zone.dart:871: *       }, zoneSpecification: new
ZoneSpecification(handleUncaughtError:
onError still supports onError.

https://codereview.chromium.org/48483002/diff/1/tests/standalone/io/http_cont...
File tests/standalone/io/http_content_length_test.dart (right):

https://codereview.chromium.org/48483002/diff/1/tests/standalone/io/http_cont...
tests/standalone/io/http_content_length_test.dart:142: onError: (e, tracerror) {
bad search/replace.

[Lasse Reichstein Nielsen, 2013-10-29 20:18:44]

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart#newco...
sdk/lib/async/zone.dart:871: *       }, zoneSpecification: new
ZoneSpecification(handleUncaughtError:
Please elaborate. What should be changed?

https://codereview.chromium.org/48483002/diff/1/tests/standalone/io/http_cont...
File tests/standalone/io/http_content_length_test.dart (right):

https://codereview.chromium.org/48483002/diff/1/tests/standalone/io/http_cont...
tests/standalone/io/http_content_length_test.dart:142: onError: (e, tracerror) {
Ack, well spotted. It even looks almost correct (and works).

[floitsch, 2013-10-29 23:31:27]

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart#newco...
sdk/lib/async/zone.dart:871: *       }, zoneSpecification: new
ZoneSpecification(handleUncaughtError:
On 2013/10/29 20:18:45, Lasse Reichstein Nielsen wrote:
> Please elaborate. What should be changed?
> 

You can just keep the old comment, and rename runZonedExperimental to runZoned.

[Lasse Reichstein Nielsen, 2013-10-30 13:32:13]

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/48483002/diff/1/sdk/lib/async/zone.dart#newco...
sdk/lib/async/zone.dart:871: *       }, zoneSpecification: new
ZoneSpecification(handleUncaughtError:
On 2013/10/29 23:31:27, floitsch wrote:
> On 2013/10/29 20:18:45, Lasse Reichstein Nielsen wrote:
> > Please elaborate. What should be changed?
> > 
> 
> You can just keep the old comment, and rename runZonedExperimental to
runZoned.

Done.

[Lasse Reichstein Nielsen, 2013-10-30 13:48:17]

Bob, please check what I've done to poor barback. :)
Have you considered making the stream of errors pass the errors as error events,
not as data events? Then it could pass stack traces with them.

Florian, I won't be able to commit this today. If you can do it tonight, it
would be great (but there will probably be some firefighting necessary).
Otherwise I'll try doing it tomorrow early, which is just in the nick of time.

[Bob Nystrom, 2013-10-30 15:56:33]

+nweiz for barback changes.

I'll talk to Nathan about using the error channel for the errors stream. I know
we had a bunch of discussion back and forth about this when we first laid that
stuff out. But, at the time, it didn't have a logging stream either, so it may
make sense to juggle some stuff around.

- bob

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:51: if (error is Error) stackTrace =
error.stackTrace;
error will always be an instance of BarbackException, so you can rely on it
having a stackTrace property, (and the is check here will always fail). You
should be able to just do:

var stackTrace = new Trace.from(error.stackTrace);

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
File pkg/barback/lib/src/errors.dart (right):

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
pkg/barback/lib/src/errors.dart:120: _WrappedException(this.error,
[this.stackTrace]);
Let's make this non-optional, here and below.

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
pkg/barback/lib/src/errors.dart:128: if (satck == null && error is Error) stack
= error.stackTrace;
"satck" -> "stack"!

[floitsch, 2013-10-30 18:23:15]

On 2013/10/30 13:48:17, Lasse Reichstein Nielsen wrote:
> Bob, please check what I've done to poor barback. :)
> Have you considered making the stream of errors pass the errors as error
events,
> not as data events? Then it could pass stack traces with them.
> 
> Florian, I won't be able to commit this today. If you can do it tonight, it
> would be great (but there will probably be some firefighting necessary).
> Otherwise I'll try doing it tomorrow early, which is just in the nick of time.

Will land once I get the ok from Seattle.

[floitsch, 2013-10-30 18:39:39]

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:51: if (error is Error) stackTrace =
error.stackTrace;
On 2013/10/30 15:56:34, Bob Nystrom wrote:
> error will always be an instance of BarbackException, so you can rely on it
> having a stackTrace property, (and the is check here will always fail). You
> should be able to just do:
> 
> var stackTrace = new Trace.from(error.stackTrace);

Done.

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
File pkg/barback/lib/src/errors.dart (right):

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
pkg/barback/lib/src/errors.dart:120: _WrappedException(this.error,
[this.stackTrace]);
On 2013/10/30 15:56:34, Bob Nystrom wrote:
> Let's make this non-optional, here and below.

Done.

https://codereview.chromium.org/48483002/diff/200001/pkg/barback/lib/src/erro...
pkg/barback/lib/src/errors.dart:128: if (satck == null && error is Error) stack
= error.stackTrace;
On 2013/10/30 15:56:34, Bob Nystrom wrote:
> "satck" -> "stack"!

Done.

[Bob Nystrom, 2013-10-30 19:47:26]

LTGM.

[nweiz, 2013-10-30 22:48:17]

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/asse...
File pkg/barback/lib/src/asset_cascade.dart (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/asse...
pkg/barback/lib/src/asset_cascade.dart:126: new
TransformerException(entry.transform, entry.message, null));
Can you add a TODO to track the stack trace of error log entries?

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:50: var stackTrace = error.stackTrace;
Most BarbackErrors don't have a [stackTrace] property. We should check if this
is a [TransformerException] or an [AssetLoadException].

https://codereview.chromium.org/48483002/diff/280001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/pkg.status#newcode388
pkg/pkg.status:388: # Issue surfaced after removing deprecated async features.
Please file an issue for this, assign it to me, and reference it here.

https://codereview.chromium.org/48483002/diff/280001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/server.dart (left):

https://codereview.chromium.org/48483002/diff/280001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/server.dart:119: var trace = new
Trace.from(getAttachedStackTrace(error));
It's important that the native trace is wrapped in [Trace], regardless of
whether it comes from [getAttachedStackTrace] or [catchError].

[floitsch, 2013-10-31 00:38:13]

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/asse...
File pkg/barback/lib/src/asset_cascade.dart (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/asse...
pkg/barback/lib/src/asset_cascade.dart:126: new
TransformerException(entry.transform, entry.message, null));
On 2013/10/30 22:48:18, nweiz wrote:
> Can you add a TODO to track the stack trace of error log entries?

Done.

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:50: var stackTrace = error.stackTrace;
On 2013/10/30 22:48:18, nweiz wrote:
> Most BarbackErrors don't have a [stackTrace] property. We should check if this
> is a [TransformerException] or an [AssetLoadException].

Done.

https://codereview.chromium.org/48483002/diff/280001/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/48483002/diff/280001/pkg/pkg.status#newcode388
pkg/pkg.status:388: # Issue surfaced after removing deprecated async features.
On 2013/10/30 22:48:18, nweiz wrote:
> Please file an issue for this, assign it to me, and reference it here.

Done.

https://codereview.chromium.org/48483002/diff/280001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/server.dart (left):

https://codereview.chromium.org/48483002/diff/280001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/server.dart:119: var trace = new
Trace.from(getAttachedStackTrace(error));
On 2013/10/30 22:48:18, nweiz wrote:
> It's important that the native trace is wrapped in [Trace], regardless of
> whether it comes from [getAttachedStackTrace] or [catchError].

Done.

[nweiz, 2013-10-31 00:41:54]

One last thing, then lgtm.

https://codereview.chromium.org/48483002/diff/410001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/410001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:51: if (error is Error ||
There's no way this will be an Error, since all members of [errors] are
[BarbackException]s and no [BarbackException]s are [Error]s.

[floitsch, 2013-10-31 00:44:19]

https://codereview.chromium.org/48483002/diff/410001/pkg/barback/lib/src/buil...
File pkg/barback/lib/src/build_result.dart (right):

https://codereview.chromium.org/48483002/diff/410001/pkg/barback/lib/src/buil...
pkg/barback/lib/src/build_result.dart:51: if (error is Error ||
On 2013/10/31 00:41:55, nweiz wrote:
> There's no way this will be an Error, since all members of [errors] are
> [BarbackException]s and no [BarbackException]s are [Error]s.

Done.

[floitsch, 2013-10-31 02:25:01]

Committed patchset #8 manually as r29628 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-10-31 06:59:29]

On 2013/10/31 02:25:01, floitsch wrote:
> Committed patchset #8 manually as r29628 (presubmit successful).

Thank you!