Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/server.dart

Issue 48483002: Remove deprecated parts of dart:async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/barback/server.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/server.dart b/sdk/lib/_internal/pub/lib/src/barback/server.dart
index ec417b1482c58428fa8b3b123c05b46fc9e29965..4c8cf596217a0739367a8d423f812fd248f22ffc 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/server.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/server.dart
@@ -104,7 +104,7 @@ class BarbackServer {
_logRequest(request, "Served $id");
request.response.close();
});
- }).catchError((error) {
+ }).catchError((error, trace) {
_resultsController.add(
new BarbackServerResult._failure(request.uri, id, error));
@@ -116,7 +116,7 @@ class BarbackServer {
return;
}
- var trace = new Trace.from(getAttachedStackTrace(error));
+ trace = new Trace.from(trace);
_logRequest(request, "$error\n$trace");
// Otherwise, it's some internal error.
@@ -125,9 +125,9 @@ class BarbackServer {
request.response.write(error);
request.response.close();
});
- }).catchError((error) {
+ }).catchError((error, trace) {
if (error is! AssetNotFoundException) {
- var trace = new Trace.from(getAttachedStackTrace(error));
+ trace = new Trace.from(trace);
_logRequest(request, "$error\n$trace");
_resultsController.addError(error);
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart ('k') | sdk/lib/_internal/pub/lib/src/command.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698