Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 484733003: Import analysis_services.dart into analysis_server.dart. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Import analysis_services.dart into analysis_server.dart. Having two separate packages doesn't really have any benefit, and has the downside of forcing us to carefully avoid circular dependencies between the two. It makes more sense to just combine them. This is largely a mechanical change consisting of the following renames: 1. pkg/analysis_services/lib/src/* -> pkg/analysis_server/lib/src/services/* 2. pkg/analysis_services/lib/* -> pkg/analysis_server/lib/src/services/* 3. pkg/analysis_services/test/* -> pkg/analysis_server/test/services/* There were 4 instances where 1 and 2 created a collision: .../services/correction/assist.dart, .../services/correction/fix.dart, .../services/refactoring/refactoring.dart, and .../services/search/search_engine_internal.dart. To fix the collision, the files coming from pkg/analysis_services/lib/src were renamed to "..._internal.dart". In addition, pkg/analysis_services/test/test_all.dart was modified to call pkg/analysis_services/test/services/test_all.dart. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -35128 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/fix.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_result.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/completion_suggestion.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/constants.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +9 lines, -9 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/change.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +10 lines, -10 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/levenshtein.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/name_suggestion.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/selection_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/source_buffer.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/source_range.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/status.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/strings.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/change.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/completion.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/proposal.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/status.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/stubs.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/util.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/index.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/index_store.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/index/local_file_index.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/local_index.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/local_memory_index.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/store/codec.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/store/collection.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/store/memory_node_manager.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/store/split_store.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/index/store/temporary_folder_file_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/json.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +9 lines, -9 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_library.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/search/element_visitors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/search/hierarchy.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/search/search_engine.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/edit_domain_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_domain_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/completion_computer_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/imported_type_computer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/completion/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/analysis_server/test/services/correction/levenshtein_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/services/correction/strings_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/correction/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/services/index/local_file_index_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/index/store/collection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/index/store/mocks.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/index/store/single_source_container.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/test/services/index/store/temporary_folder_file_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/index/store/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/index/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/refactoring/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/analysis_server/test/services/search/test_all.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/services/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
D pkg/analysis_services/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/analysis_services/lib/completion/completion_manager.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D pkg/analysis_services/lib/completion/completion_suggestion.dart View 1 chunk +0 lines, -237 lines 0 comments Download
D pkg/analysis_services/lib/constants.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D pkg/analysis_services/lib/correction/assist.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D pkg/analysis_services/lib/correction/change.dart View 1 chunk +0 lines, -361 lines 0 comments Download
D pkg/analysis_services/lib/correction/fix.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D pkg/analysis_services/lib/correction/status.dart View 1 chunk +0 lines, -399 lines 0 comments Download
D pkg/analysis_services/lib/index/index.dart View 1 chunk +0 lines, -379 lines 0 comments Download
D pkg/analysis_services/lib/index/index_store.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D pkg/analysis_services/lib/index/local_file_index.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/analysis_services/lib/index/local_memory_index.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/analysis_services/lib/json.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/analysis_services/lib/refactoring/refactoring.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D pkg/analysis_services/lib/search/element_visitors.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D pkg/analysis_services/lib/search/hierarchy.dart View 1 chunk +0 lines, -211 lines 0 comments Download
D pkg/analysis_services/lib/search/search_engine.dart View 1 chunk +0 lines, -197 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/dart_completion_manager.dart View 1 chunk +0 lines, -191 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/imported_type_computer.dart View 1 chunk +0 lines, -198 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/invocation_computer.dart View 1 chunk +0 lines, -166 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/keyword_computer.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/local_computer.dart View 1 chunk +0 lines, -197 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/assist.dart View 1 chunk +0 lines, -1589 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/fix.dart View 1 chunk +0 lines, -1912 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/levenshtein.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/name_suggestion.dart View 1 chunk +0 lines, -255 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/selection_analyzer.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/source_buffer.dart View 1 chunk +0 lines, -106 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/source_range.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/statement_analyzer.dart View 1 chunk +0 lines, -233 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/strings.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D pkg/analysis_services/lib/src/correction/util.dart View 1 chunk +0 lines, -923 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/change.dart View 1 chunk +0 lines, -178 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/completion.dart View 1 chunk +0 lines, -3705 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/proposal.dart View 1 chunk +0 lines, -309 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/status.dart View 1 chunk +0 lines, -370 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/stubs.dart View 1 chunk +0 lines, -153 lines 0 comments Download
D pkg/analysis_services/lib/src/generated/util.dart View 1 chunk +0 lines, -2437 lines 0 comments Download
D pkg/analysis_services/lib/src/index/index_contributor.dart View 1 chunk +0 lines, -1183 lines 0 comments Download
D pkg/analysis_services/lib/src/index/local_index.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D pkg/analysis_services/lib/src/index/store/codec.dart View 1 chunk +0 lines, -253 lines 0 comments Download
D pkg/analysis_services/lib/src/index/store/collection.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D pkg/analysis_services/lib/src/index/store/memory_node_manager.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D pkg/analysis_services/lib/src/index/store/split_store.dart View 1 chunk +0 lines, -916 lines 0 comments Download
D pkg/analysis_services/lib/src/index/store/temporary_folder_file_manager.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/naming_conventions.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/refactoring.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename.dart View 1 chunk +0 lines, -250 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_class_member.dart View 1 chunk +0 lines, -241 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_constructor.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_import.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_library.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_local.dart View 1 chunk +0 lines, -142 lines 0 comments Download
D pkg/analysis_services/lib/src/refactoring/rename_unit_member.dart View 1 chunk +0 lines, -252 lines 0 comments Download
D pkg/analysis_services/lib/src/search/search_engine.dart View 1 chunk +0 lines, -312 lines 0 comments Download
D pkg/analysis_services/pubspec.yaml View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/analysis_services/test/completion/completion_computer_test.dart View 1 chunk +0 lines, -191 lines 0 comments Download
D pkg/analysis_services/test/completion/completion_manager_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D pkg/analysis_services/test/completion/completion_test_util.dart View 1 chunk +0 lines, -208 lines 0 comments Download
D pkg/analysis_services/test/completion/imported_type_computer_test.dart View 1 chunk +0 lines, -207 lines 0 comments Download
D pkg/analysis_services/test/completion/invocation_computer_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/analysis_services/test/completion/keyword_computer_test.dart View 1 chunk +0 lines, -73 lines 0 comments Download
D pkg/analysis_services/test/completion/local_computer_test.dart View 1 chunk +0 lines, -161 lines 0 comments Download
D pkg/analysis_services/test/completion/test_all.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/analysis_services/test/correction/assist_test.dart View 1 chunk +0 lines, -2247 lines 0 comments Download
D pkg/analysis_services/test/correction/change_test.dart View 1 chunk +0 lines, -346 lines 0 comments Download
D pkg/analysis_services/test/correction/fix_test.dart View 1 chunk +0 lines, -1880 lines 0 comments Download
D pkg/analysis_services/test/correction/levenshtein_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D pkg/analysis_services/test/correction/name_suggestion_test.dart View 1 chunk +0 lines, -376 lines 0 comments Download
D pkg/analysis_services/test/correction/source_range_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D pkg/analysis_services/test/correction/status_test.dart View 1 chunk +0 lines, -271 lines 0 comments Download
D pkg/analysis_services/test/correction/strings_test.dart View 1 chunk +0 lines, -145 lines 0 comments Download
D pkg/analysis_services/test/correction/test_all.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/analysis_services/test/index/dart_index_contributor_test.dart View 1 chunk +0 lines, -1728 lines 0 comments Download
D pkg/analysis_services/test/index/local_file_index_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/analysis_services/test/index/local_index_test.dart View 1 chunk +0 lines, -150 lines 0 comments Download
D pkg/analysis_services/test/index/store/codec_test.dart View 1 chunk +0 lines, -230 lines 0 comments Download
D pkg/analysis_services/test/index/store/collection_test.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D pkg/analysis_services/test/index/store/mocks.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D pkg/analysis_services/test/index/store/single_source_container.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D pkg/analysis_services/test/index/store/split_store_test.dart View 1 chunk +0 lines, -1131 lines 0 comments Download
D pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D pkg/analysis_services/test/index/store/test_all.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/analysis_services/test/index/test_all.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/analysis_services/test/refactoring/abstract_refactoring.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D pkg/analysis_services/test/refactoring/abstract_rename.dart View 1 chunk +0 lines, -154 lines 0 comments Download
D pkg/analysis_services/test/refactoring/naming_conventions_test.dart View 1 chunk +0 lines, -728 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_class_member_test.dart View 1 chunk +0 lines, -734 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_constructor_test.dart View 1 chunk +0 lines, -194 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_import_test.dart View 1 chunk +0 lines, -149 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_library_test.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_local_test.dart View 1 chunk +0 lines, -472 lines 0 comments Download
D pkg/analysis_services/test/refactoring/rename_unit_member_test.dart View 1 chunk +0 lines, -521 lines 0 comments Download
D pkg/analysis_services/test/refactoring/test_all.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D pkg/analysis_services/test/search/hierarchy_test.dart View 1 chunk +0 lines, -322 lines 0 comments Download
D pkg/analysis_services/test/search/search_engine_test.dart View 1 chunk +0 lines, -665 lines 0 comments Download
D pkg/analysis_services/test/search/test_all.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/analysis_services/test/test_all.dart View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-18 18:59:23 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-18 19:31:43 UTC) #2
scheglov
LGTM
6 years, 4 months ago (2014-08-18 19:41:29 UTC) #3
Paul Berry
6 years, 4 months ago (2014-08-18 20:19:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698