Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Side by Side Diff: pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart

Issue 484733003: Import analysis_services.dart into analysis_server.dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library services.src.refactoring.naming_conventions; 5 library services.src.refactoring.naming_conventions;
6 6
7 import 'package:analysis_services/correction/status.dart'; 7 import 'package:analysis_server/src/services/correction/status.dart';
8 import 'package:analysis_services/src/correction/strings.dart'; 8 import 'package:analysis_server/src/services/correction/strings.dart';
9 9
10 10
11 /** 11 /**
12 * Returns the [RefactoringStatus] with severity: 12 * Returns the [RefactoringStatus] with severity:
13 * OK if the name is valid; 13 * OK if the name is valid;
14 * WARNING if the name is discouraged; 14 * WARNING if the name is discouraged;
15 * ERROR if the name is illegal. 15 * ERROR if the name is illegal.
16 */ 16 */
17 RefactoringStatus validateClassName(String name) { 17 RefactoringStatus validateClassName(String name) {
18 return _validateUpperCamelCase(name, "Class"); 18 return _validateUpperCamelCase(name, "Class");
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 } 271 }
272 // does not start with upper case 272 // does not start with upper case
273 if (!isUpperCase(identifier.codeUnitAt(0))) { 273 if (!isUpperCase(identifier.codeUnitAt(0))) {
274 // By convention, class names usually start with an uppercase letter 274 // By convention, class names usually start with an uppercase letter
275 String message = "$desc should start with an uppercase letter."; 275 String message = "$desc should start with an uppercase letter.";
276 return new RefactoringStatus.warning(message); 276 return new RefactoringStatus.warning(message);
277 } 277 }
278 // OK 278 // OK
279 return new RefactoringStatus(); 279 return new RefactoringStatus();
280 } 280 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/services/json.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/refactoring.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698