Improve polymorphic inlining of int/int double/double operations.

Improve polymorphic inlining of int/int double/double operations.

I added inlining of the native Double methods _add, _sub, _mul and _div and fromInteger
and unified the method recognition of the MethodRecognizer and the Intrinsifier classes.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39446

[srdjan, 2014-08-18 18:04:49]

lgtm

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm.cc:1300: uword label_address =
const uword

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1305: uword label_address =
const uword, here and on other architectures as well.

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:2799: intptr_t cid,  // Not used.
Why pass if not used?

https://codereview.chromium.org/484693003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:489: const char* function_name =
String::Handle(function.name()).ToCString();
ToCString is expensive, should not be used in performance critical code. AFAIK,
MethodRecognizer appears in the profile of compilation. I fear this would have
negative impact on compilation speed.

What is the reason for these changes?

[Florian Schneider, 2014-08-18 18:22:57]

I'll look at the performance impact of using ToCString and change it if
necessary.

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm.cc:1300: uword label_address =
On 2014/08/18 18:04:49, srdjan wrote:
> const uword

Done.

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm64.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm64.cc:1305: uword label_address =
On 2014/08/18 18:04:49, srdjan wrote:
> const uword, here and on other architectures as well.

Done.

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:2799: intptr_t cid,  // Not used.
On 2014/08/18 18:04:49, srdjan wrote:
> Why pass if not used?

Done.

https://codereview.chromium.org/484693003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/484693003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:489: const char* function_name =
String::Handle(function.name()).ToCString();
On 2014/08/18 18:04:49, srdjan wrote:
> ToCString is expensive, should not be used in performance critical code.
AFAIK,
> MethodRecognizer appears in the profile of compilation. I fear this would have
> negative impact on compilation speed.
> 
> What is the reason for these changes?

The reason was that I use the existing comparison code from the intrinsifier
which uses C strings only and can handle factory constructors. If it turns out
to be performance-critical I can change both (MethodRecognizer and Intrinsifier)
to avoid ToCString.

[Florian Schneider, 2014-08-20 15:18:56]

I'm waiting with landing this after landing my CL to refactor the method
recognizer and improve its performance.

[Florian Schneider, 2014-08-21 11:13:57]

Committed patchset #3 manually as r39446 (presubmit successful).