runtime/vm/intermediate_language.cc - Issue 484693003: Improve polymorphic inlining of int/int double/double operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 484693003: Improve polymorphic inlining of int/int double/double operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: rebased and addressed comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 39445)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -2312,9 +2312,16 @@

MethodRecognizer::Kind recognized_kind =

MethodRecognizer::RecognizeKind(function());

int num_args_checked = 0;

- if ((recognized_kind == MethodRecognizer::kMathMin) ||

- (recognized_kind == MethodRecognizer::kMathMax)) {

- num_args_checked = 2;

+ switch (recognized_kind) {

+ case MethodRecognizer::kDoubleFromInteger:

+ num_args_checked = 1;

+ break;

+ case MethodRecognizer::kMathMin:

+ case MethodRecognizer::kMathMax:

+ num_args_checked = 2;

+ break;

+ default:

+ break;

}

call_ic_data = compiler->GetOrAddStaticCallICData(deopt_id(),

function(),

« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/method_recognizer.h » ('j') | no next file with comments »