Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 48403004: Use UTF8-decoding for headers in mime multipart parser. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use UTF8-decoding for headers in mime multipart parser. BUG=http://code.google.com/p/dart/issues/detail?id=14303 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29526

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M pkg/mime/lib/mime.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/mime/lib/src/mime_multipart_transformer.dart View 6 chunks +11 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-30 09:53:30 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/48403004/diff/1/pkg/mime/lib/src/mime_multipart_transformer.dart File pkg/mime/lib/src/mime_multipart_transformer.dart (right): https://codereview.chromium.org/48403004/diff/1/pkg/mime/lib/src/mime_multipart_transformer.dart#newcode292 pkg/mime/lib/src/mime_multipart_transformer.dart:292: String headerField = UTF8.decode(_headerField); Should there be a ...
7 years, 1 month ago (2013-10-30 10:08:08 UTC) #2
Anders Johnsen
https://codereview.chromium.org/48403004/diff/1/pkg/mime/lib/src/mime_multipart_transformer.dart File pkg/mime/lib/src/mime_multipart_transformer.dart (right): https://codereview.chromium.org/48403004/diff/1/pkg/mime/lib/src/mime_multipart_transformer.dart#newcode292 pkg/mime/lib/src/mime_multipart_transformer.dart:292: String headerField = UTF8.decode(_headerField); On 2013/10/30 10:08:09, Søren Gjesse ...
7 years, 1 month ago (2013-10-30 10:34:03 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-10-30 10:34:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698