Use UTF8-decoding for headers in mime multipart parser.

pkg/mime/lib/src/mime_multipart_transformer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of mime;
 
 
 /**
  * A Mime Multipart class representing each part parsed by
  * [MimeMultipartTransformer]. The data is streamed in as it become available.
@@ skipping 68 matching lines @@
 
   List<int> _boundary;
   int _state = _START;
   int _boundaryIndex = 2;
 
   // Current index in the data buffer. If index is negative then it
   // is the index into the artificial prefix of the boundary string.
   int _index;
   List<int> _buffer;
 
-  StringBuffer _headerField = new StringBuffer();
-  StringBuffer _headerValue = new StringBuffer();
+  List<int> _headerField = [];
+  List<int> _headerValue = [];
 
   /**
    * Construct a new MIME multipart parser with the boundary
    * [boundary]. The boundary should be as specified in the content
    * type parameter, that is without the -- prefix.
    */
   MimeMultipartTransformer(String boundary) {
     List<int> charCodes = boundary.codeUnits;
     _boundary = new Uint8List(4 + charCodes.length);
     // Set-up the matching boundary preceding it with CRLF and two
@@ skipping 138 matching lines @@
           _multipartController = null;
           _state = _HEADER_START;
           break;
 
         case _HEADER_START:
           _headers = new Map<String, String>();
           if (byte == _CharCode.CR) {
             _state = _HEADER_ENDING;
           } else {
             // Start of new header field.
-            _headerField.writeCharCode(_toLowerCase(byte));
+            _headerField.add(_toLowerCase(byte));
             _state = _HEADER_FIELD;
           }
           break;
 
         case _HEADER_FIELD:
           if (byte == _CharCode.COLON) {
             _state = _HEADER_VALUE_START;
           } else {
             if (!_isTokenChar(byte)) {
               throw new MimeMultipartException("Invalid header field name");
             }
-            _headerField.writeCharCode(_toLowerCase(byte));
+            _headerField.add(_toLowerCase(byte));
           }
           break;
 
         case _HEADER_VALUE_START:
           if (byte == _CharCode.CR) {
             _state = _HEADER_VALUE_FOLDING_OR_ENDING;
           } else if (byte != _CharCode.SP && byte != _CharCode.HT) {
             // Start of new header value.
-            _headerValue.writeCharCode(byte);
+            _headerValue.add(byte);
             _state = _HEADER_VALUE;
           }
           break;
 
         case _HEADER_VALUE:
           if (byte == _CharCode.CR) {
             _state = _HEADER_VALUE_FOLDING_OR_ENDING;
           } else {
-            _headerValue.writeCharCode(byte);
+            _headerValue.add(byte);
           }
           break;
 
         case _HEADER_VALUE_FOLDING_OR_ENDING:
           _expect(byte, _CharCode.LF);
           _state = _HEADER_VALUE_FOLD_OR_END;
           break;
 
         case _HEADER_VALUE_FOLD_OR_END:
           if (byte == _CharCode.SP || byte == _CharCode.HT) {
             _state = _HEADER_VALUE_START;
           } else {
-            String headerField = _headerField.toString();
-            String headerValue =_headerValue.toString();
+            String headerField = UTF8.decode(_headerField);

[Søren Gjesse, 2013/10/30 10:08:09]

Should there be a way of configuring this?

[Anders Johnsen, 2013/10/30 10:34:04]

I don't think so. The only behavior I've seen has been either ASCII or UTF8. I
think it's safer to trow an exception when we get odd headers.

+            String headerValue = UTF8.decode(_headerValue);
             _headers[headerField.toLowerCase()] = headerValue;
-            _headerField = new StringBuffer();
-            _headerValue = new StringBuffer();
+            _headerField = [];
+            _headerValue = [];
             if (byte == _CharCode.CR) {
               _state = _HEADER_ENDING;
             } else {
               // Start of new header field.
-              _headerField.writeCharCode(_toLowerCase(byte));
+              _headerField.add(_toLowerCase(byte));
               _state = _HEADER_FIELD;
             }
           }
           break;
 
         case _HEADER_ENDING:
           _expect(byte, _CharCode.LF);
           _multipartController = new StreamController(
               sync: true,
               onPause: () {
@@ skipping 97 matching lines @@
     }
   }
 }
 
 
 class MimeMultipartException implements Exception {
   const MimeMultipartException([String this.message = ""]);
   String toString() => "MimeMultipartException: $message";
   final String message;
 }