Issue 483393002: Analysis server code generation improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 483393002: Analysis server code generation improvements (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Analysis server code generation improvements - Make generated code implement the HasToJson interface. - Add toRequest() convenience methods to classes representing request parameters. - Fix toJson() for objects containing lists (forgot to call toList()). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39375

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+261 lines, -139 lines)			Patch
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	136 chunks	+206 lines, -118 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol.dart	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/protocol2.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_dart_protocol.dart	View	4 chunks	+23 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/implied_types.dart	View	3 chunks	+22 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-19 18:26:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39375 (presubmit successful).

Expand Messages | Collapse Messages