Analysis server code generation improvements

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:collection';
 import 'dart:convert' show JsonDecoder;
 
 import 'package:analysis_server/src/services/json.dart';
@@ skipping 62 matching lines @@
   final String id;
 
   /**
    * The method being requested.
    */
   final String method;
 
   /**
    * A table mapping the names of request parameters to their values.
    */
-  final Map<String, Object> params = new HashMap<String, Object>();
+  final Map<String, Object> params;
 
   /**
    * A decoder that can be used to decode strings into JSON objects.
    */
   static const JsonDecoder DECODER = const JsonDecoder(null);
 
   /**
    * Initialize a newly created [Request] to have the given [id] and [method]
-   * name.
+   * name.  If [params] is supplied, it is used as the "params" map for the
+   * request.  Otherwise an empty "params" map is allocated.
    */
-  Request(this.id, this.method);
+  Request(this.id, this.method, [Map<String, Object> params])
+      : params = params != null ? params : new HashMap<String, Object>();
 
   /**
    * Return a request parsed from the given [data], or `null` if the [data] is
    * not a valid json representation of a request. The [data] is expected to
    * have the following format:
    *
    *   {
    *     'id': String,
    *     'method': methodName,
    *     'params': {
    *       paramter_name: value
    *     }
    *   }
    *
    * where the parameters are optional and can contain any number of name/value
    * pairs.
    */
   factory Request.fromString(String data) {
     try {
       var result = DECODER.convert(data);
       if (result is! Map) {
         return null;
       }
       var id = result[Request.ID];
       var method = result[Request.METHOD];
       if (id is! String || method is! String) {
         return null;
       }
       var params = result[Request.PARAMS];
-      Request request = new Request(id, method);
-      if (params is Map) {
-        params.forEach((String key, Object value) {
-          request.setParameter(key, value);
-        });
-      } else if (params != null) {
+      if (params is Map || params == null) {
+        return new Request(id, method, params);
+      } else {
         return null;
       }
-      return request;
     } catch (exception) {
       return null;
     }
   }
 
   /**
    * Return the value of the parameter with the given [name], or [defaultValue]
    * if there is no such parameter associated with this request.
    */
   RequestDatum getParameter(String name, defaultValue) {
@@ skipping 812 matching lines @@
  */
 _toJson(Object value) {
   if (value is HasToJson) {
     return value.toJson();
   }
   if (value is Iterable) {
     return value.map((item) => _toJson(item)).toList();
   }
   return value;
 }