Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 48213002: Fix warnings in dart2js. (Closed)

Created:
7 years, 1 month ago by kasperl
Modified:
7 years, 1 month ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, Brian Wilkerson
Visibility:
Public.

Description

Fix warnings in dart2js. R=ngeoffray@google.com BUG=http://dartbug.com/14469 Committed: https://code.google.com/p/dart/source/detail?r=29345

Patch Set 1 #

Patch Set 2 : Remove (). #

Patch Set 3 : Update utils.status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 1 chunk +11 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 2 chunks +10 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/printer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/utils/utils.status View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 1 month ago (2013-10-28 08:07:01 UTC) #1
ngeoffray
LGTM!
7 years, 1 month ago (2013-10-28 08:18:25 UTC) #2
kasperl
7 years, 1 month ago (2013-10-28 08:23:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r29345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698