Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 48213002: Fix warnings in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update utils.status. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index bab8bfe1723144fd74b2153eed956a856b015106..015402a3b49b7bc5a7b69fcfec5208f8db817a64 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -461,7 +461,7 @@ class ResolverTask extends CompilerTask {
FunctionExpression tree = element.parseNode(compiler);
if (tree.modifiers.isExternal()) {
error(tree, MessageKind.PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION);
- return;
+ return null;
}
if (isConstructor || element.isFactoryConstructor()) {
if (tree.returnType != null) {
@@ -2602,7 +2602,7 @@ class ResolverVisitor extends MappingVisitor<Element> {
// If the selector is null, it means that we will not be generating
// code for this as a send.
Selector selector = mapping.getSelector(node);
- if (selector == null) return;
+ if (selector == null) return null;
if (node.isCall) {
if (Elements.isUnresolved(target) ||

Powered by Google App Engine
This is Rietveld 408576698