Issue 481173002: When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement.

Issue 481173002: When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

When user renames 'prefix' in 'prefix.Class' she actually wants to rename ImportElement. Unfortunately we resolve "prefix" to a "PrefixElement". So, we have to fix this mismatch in the server. We do the same in indexer, so this CL extract shared namespace-related code into a new unit. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39356

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak for test - reference ambiguous prefix name. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -204 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		7 chunks	+23 lines, -25 lines	0 comments	Download
A	pkg/analysis_server/lib/src/services/correction/namespace.dart	View		1 chunk	+189 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View		1 chunk	+0 lines, -29 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View		6 chunks	+5 lines, -146 lines	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	1	3 chunks	+26 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/abstract_rename.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_import_test.dart	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/481173002/diff/1/pkg/analysis_server/test/edit/refactoring_test.dart File pkg/analysis_server/test/edit/refactoring_test.dart (right): https://codereview.chromium.org/481173002/diff/1/pkg/analysis_server/test/edit/refactoring_test.dart#newcode98 pkg/analysis_server/test/edit/refactoring_test.dart:98: Future test_rename_hasElement_importElement_prefixRef() { Possibly test an ambiguous case.

6 years, 4 months ago (2014-08-18 21:42:34 UTC) #2

scheglov

Committed patchset #2 manually as 39356 (presubmit successful).

6 years, 4 months ago (2014-08-18 21:49:20 UTC) #3

scheglov

6 years, 4 months ago (2014-08-18 21:49:41 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/481173002/diff/1/pkg/analysis_server/test/edi...
File pkg/analysis_server/test/edit/refactoring_test.dart (right):

https://codereview.chromium.org/481173002/diff/1/pkg/analysis_server/test/edi...
pkg/analysis_server/test/edit/refactoring_test.dart:98: Future
test_rename_hasElement_importElement_prefixRef() {
On 2014/08/18 21:42:34, Brian Wilkerson wrote:
> Possibly test an ambiguous case.

Done.

Expand Messages | Collapse Messages