Control whether pub build and serve minify or not.

Control whether pub build and serve minify or not.

BUG=https://code.google.com/p/dart/issues/detail?id=14539
R=nweiz@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29502

[Bob Nystrom, 2013-10-29 22:54:21]

By default, pub build will generate minified JS and pub serve will generate
unminified.

You can get the opposite behavior using:

pub build --no-minify
pub serve --minify

[Siggi Cherem (dart-lang), 2013-10-29 22:57:39]

nice

lgtm

[nweiz, 2013-10-29 23:18:52]

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/build.dart:95: var s = assets.length == 1
? "" : "s";
There's a [pluralize] function in utils.dart.

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/dart.dart:38: compiler.DiagnosticHandler
diagnosticHandler}) {
What are the criteria for whether a set or parameters gets split one per line or
not?

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/bu...
File
sdk/lib/_internal/pub/test/build/takes_flag_to_disable_minification_test.dart
(right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/bu...
sdk/lib/_internal/pub/test/build/takes_flag_to_disable_minification_test.dart:13:
integration("generates minified JavaScript", () {
Wrong test name.

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:65: Matcher minifiedDart2JSOutput =
These should follow the matcher naming convention of being a verb phrase that
describes the output that's matched. So in this case, "isMinifiedDart2JSOutput".

[nweiz, 2013-10-29 23:19:14]

Forgot to say: LGTM with a few comments.

[Bob Nystrom, 2013-10-29 23:53:00]

Committed patchset #2 manually as r29502 (presubmit successful).

[Bob Nystrom, 2013-10-29 23:53:24]

Thanks!

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/command/build.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/command/build.dart:95: var s = assets.length == 1
? "" : "s";
On 2013/10/29 23:18:53, nweiz wrote:
> There's a [pluralize] function in utils.dart.

Done.

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/dart.dart:38: compiler.DiagnosticHandler
diagnosticHandler}) {
On 2013/10/29 23:18:53, nweiz wrote:
> What are the criteria for whether a set or parameters gets split one per line
or
> not?

Good question. I pulled the trigger here because it was starting to look nasty
to me at this point. I don't have a precise guideline.

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/bu...
File
sdk/lib/_internal/pub/test/build/takes_flag_to_disable_minification_test.dart
(right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/bu...
sdk/lib/_internal/pub/test/build/takes_flag_to_disable_minification_test.dart:13:
integration("generates minified JavaScript", () {
On 2013/10/29 23:18:53, nweiz wrote:
> Wrong test name.

Done.

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/te...
File sdk/lib/_internal/pub/test/test_pub.dart (right):

https://codereview.chromium.org/47793003/diff/1/sdk/lib/_internal/pub/test/te...
sdk/lib/_internal/pub/test/test_pub.dart:65: Matcher minifiedDart2JSOutput =
On 2013/10/29 23:18:53, nweiz wrote:
> These should follow the matcher naming convention of being a verb phrase that
> describes the output that's matched. So in this case,
"isMinifiedDart2JSOutput".

Done.