sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart - Issue 47793003: Control whether pub build and serve minify or not.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart

Issue 47793003: Control whether pub build and serve minify or not. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Revise. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_if_disabled_test.dart ('k') | sdk/lib/_internal/pub/test/transformer/dart2js/unminified_by_default_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart

diff --git a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_if_disabled_test.dart b/sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart

similarity index 76%

copy from sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_if_disabled_test.dart

copy to sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart

index fc9066755aa287f857f12e288335de93e2d2ebd2..e385237589af0e1ba42a0131caf5048d1e6fefc8 100644

--- a/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_if_disabled_test.dart

+++ b/sdk/lib/_internal/pub/test/transformer/dart2js/takes_flag_minify_test.dart

@@ -10,7 +10,7 @@ import '../../serve/utils.dart';

main() {

initConfig();

- integration("does not compile if dart2js is disabled", () {

+ integration("generates minified JS if the flag is set", () {

d.dir(appPath, [

d.appPubspec(),

d.dir("web", [

@@ -18,8 +18,8 @@ main() {

])

]).create();

- startPubServe(dart2js: false);

- requestShould404("main.dart.js");

+ startPubServe(args: ["--minify"]);

+ requestShouldSucceed("main.dart.js", isMinifiedDart2JSOutput);

endPubServe();

});

}