Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 477323005: Use generated classes to create requests in analysis server unit tests. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use generated classes to create requests in analysis server unit tests. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -166 lines) Patch
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 5 chunks +9 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 18 chunks +50 lines, -78 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 2 chunks +5 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/edit/edit_domain_test.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/search_domain_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-19 20:23:21 UTC) #1
jwren
LGTM
6 years, 4 months ago (2014-08-19 20:27:08 UTC) #2
Paul Berry
Committed patchset #1 manually as 39381 (presubmit successful).
6 years, 4 months ago (2014-08-19 20:36:27 UTC) #3
danrubel
6 years, 4 months ago (2014-08-19 21:11:45 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698