Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: pkg/analysis_server/test/edit/edit_domain_test.dart

Issue 477323005: Use generated classes to create requests in analysis server unit tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/edit/assists_test.dart ('k') | pkg/analysis_server/test/edit/fixes_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/edit/edit_domain_test.dart
diff --git a/pkg/analysis_server/test/edit/edit_domain_test.dart b/pkg/analysis_server/test/edit/edit_domain_test.dart
index 70c630f417176aea69752894e5bc738c8fb5b322..107a23975fbd57ff52a0282c780ea6a81702971c 100644
--- a/pkg/analysis_server/test/edit/edit_domain_test.dart
+++ b/pkg/analysis_server/test/edit/edit_domain_test.dart
@@ -5,9 +5,8 @@
library test.domain.edit;
import 'package:analysis_server/src/analysis_server.dart';
-import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/edit/edit_domain.dart';
-import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_testing/mock_sdk.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:unittest/unittest.dart';
@@ -33,21 +32,21 @@ main() {
group('EditDomainHandler', () {
test('getAssists', () {
- var request = new Request('0', EDIT_GET_ASSISTS);
- request.setParameter(FILE, null);
- request.setParameter(OFFSET, null);
- request.setParameter(LENGTH, null);
+ // TODO(paulberry): Why are we passing null here?
+ var request = new EditGetAssistsParams(null, null, null).toRequest('0');
var response = handler.handleRequest(request);
// TODO(brianwilkerson) implement
//expect(response, isNull);
});
test('getFixes', () {
- var request = new Request('0', EDIT_GET_FIXES);
- request.setParameter(ERRORS, []);
- var response = handler.handleRequest(request);
- // TODO(brianwilkerson) implement
- //expect(response, isNull);
+ // TODO(paulberry): Test not yet written, and the code below doesn't
+ // follow the API.
+// var request = new Request('0', EDIT_GET_FIXES);
+// request.setParameter(ERRORS, []);
+// var response = handler.handleRequest(request);
+// // TODO(brianwilkerson) implement
+// //expect(response, isNull);
});
});
}
« no previous file with comments | « pkg/analysis_server/test/edit/assists_test.dart ('k') | pkg/analysis_server/test/edit/fixes_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698