Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 475673002: Generate public static EMPTY_ARRAY fields for each object. (Closed)

Created:
6 years, 4 months ago by jwren
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, ricow1, scheglov, danrubel
Visibility:
Public.

Description

Generate public static EMPTY_ARRAY fields for each object. Order the fields by the ordering in the spec instead of alphabetically. R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=39243

Patch Set 1 #

Total comments: 5

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -181 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java View 1 chunk +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisError.java View 2 chunks +16 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisService.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisStatus.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ChangeContentOverlay.java View 1 chunk +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionRelevance.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java View 4 chunks +47 lines, -42 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestionKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/DebugService.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java View 2 chunks +16 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ElementKind.java View 2 chunks +4 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Error.java View 2 chunks +10 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorFixes.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorSeverity.java View 1 chunk +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorType.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExecutableFile.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExecutableKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FoldingKind.java View 1 chunk +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FoldingRegion.java View 2 chunks +9 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HighlightRegion.java View 2 chunks +9 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HighlightRegionType.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HoverInformation.java View 3 chunks +20 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditGroup.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditSuggestion.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditSuggestionKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Location.java View 3 chunks +11 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/NavigationRegion.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Occurrences.java View 2 chunks +9 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java View 2 chunks +11 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverriddenMember.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverrideMember.java View 2 chunks +12 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Parameter.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Position.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringProblem.java View 2 chunks +9 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringProblemSeverity.java View 1 chunk +4 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RemoveContentOverlay.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java View 2 chunks +11 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ServerService.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceChange.java View 2 chunks +10 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceEdit.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceFileEdit.java View 2 chunks +7 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/TypeHierarchyItem.java View 4 chunks +17 lines, -12 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 1 4 chunks +17 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jwren
6 years, 4 months ago (2014-08-14 05:51:12 UTC) #1
jwren
6 years, 4 months ago (2014-08-14 05:51:32 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart File pkg/analysis_server/tool/spec/codegen_java.dart (right): https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart#newcode107 pkg/analysis_server/tool/spec/codegen_java.dart:107: allFields.addAll(_state.privateFields.values.toList()); I believe ".toList()" can be omitted since ...
6 years, 4 months ago (2014-08-14 05:58:29 UTC) #3
jwren
https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart File pkg/analysis_server/tool/spec/codegen_java.dart (right): https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart#newcode107 pkg/analysis_server/tool/spec/codegen_java.dart:107: allFields.addAll(_state.privateFields.values.toList()); I thought so too, but this comes out ...
6 years, 4 months ago (2014-08-14 06:20:29 UTC) #4
jwren
Committed patchset #2 manually as 39243 (presubmit successful).
6 years, 4 months ago (2014-08-14 06:22:15 UTC) #5
Paul Berry
https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart File pkg/analysis_server/tool/spec/codegen_java.dart (right): https://codereview.chromium.org/475673002/diff/1/pkg/analysis_server/tool/spec/codegen_java.dart#newcode107 pkg/analysis_server/tool/spec/codegen_java.dart:107: allFields.addAll(_state.privateFields.values.toList()); On 2014/08/14 06:20:29, jwren wrote: > I thought ...
6 years, 4 months ago (2014-08-14 12:47:37 UTC) #6
Brian Wilkerson
6 years, 4 months ago (2014-08-14 13:40:51 UTC) #7
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698