Generate public static EMPTY_ARRAY fields for each object.

pkg/analysis_server/tool/spec/codegen_java.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Tools for Java code generation.
  */
 library CodegenJava;
 
 import 'package:html5lib/dom.dart' as dom;
@@ skipping 37 matching lines @@
         toHtmlVisitor = new ToHtmlVisitor(api);
 
   /**
    * Convenience method for subclasses for calling docComment.
    */
   void javadocComment(List<dom.Node> docs) {
     docComment(docs, width: 99, javadocStyle: true);
   }
 
   /**
+   * Create a public field, using [callback] to create its contents.
+   */
+  void publicField(String fieldName, void callback()) {
+    _state.publicFields[fieldName] = collectCode(callback);
+  }
+
+  /**
    * Create a private field, using [callback] to create its contents.
    */
   void privateField(String fieldName, void callback()) {
     _state.privateFields[fieldName] = collectCode(callback);
   }
 
   /**
    * Create a constructor, using [callback] to create its contents.
    */
   void constructor(String name, void callback()) {
@@ skipping 21 matching lines @@
    * opening brace.
    */
   void makeClass(String header, void callback()) {
     _CodegenJavaState oldState = _state;
     try {
       _state = new _CodegenJavaState();
       callback();
       writeln('$header {');
       indent(() {
         // fields
-        List<String> allFields =
-            _valuesSortedByKey(_state.privateFields).toList();
+        List<String> allFields = _state.publicFields.values.toList();
+        allFields.addAll(_state.privateFields.values.toList());

[Paul Berry, 2014/08/14 05:58:29]

I believe ".toList()" can be omitted since _state.privateFields.values has type
Iterable.

[jwren, 2014/08/14 06:20:29]

I thought so too, but this comes out of the VM if I remove toList:
Unhandled exception:
type '_LinkedHashMapValueIterable<String>' is not a subtype of type
'List<String>' of 'allFields'.

[Paul Berry, 2014/08/14 12:47:37]

That happens if you remove the toList() on line 106.  But if you remove the
toList() on line 107 you should be fine.

         for (String field in allFields) {
           writeln();
           write(field);
         }
 
         // constructors
-        List<String> allConstructors =
-            _valuesSortedByKey(_state.constructors).toList();
+        List<String> allConstructors =_state.constructors.values.toList();
         for (String constructor in allConstructors) {
           writeln();
           write(constructor);
         }
 
-        // methods
+        // methods (ordered by method name)
         List<String> allMethods =
             _valuesSortedByKey(_state.publicMethods).toList();
         allMethods.addAll(_valuesSortedByKey(_state.privateMethods));
         for (String method in allMethods) {
           writeln();
           write(method);
         }
+        writeln();
       });
       writeln('}');
     } finally {
       _state = oldState;
     }
   }
 
   /**
    * Convert the given [TypeDecl] to a Java type.
    */
@@ skipping 90 matching lines @@
    * Temporary storage for public methods.
    */
   Map<String, String> publicMethods = <String, String>{};
 
   /**
    * Temporary storage for private methods.
    */
   Map<String, String> privateMethods = <String, String>{};
 
   /**
    * Temporary storage for private fields.

[Paul Berry, 2014/08/14 05:58:29]

s/private/public/

[jwren, 2014/08/14 06:20:29]

Done.

    */
+  Map<String, String> publicFields = <String, String>{};
+
+  /**
+   * Temporary storage for private fields.
+   */
   Map<String, String> privateFields = <String, String>{};
 
   /**
    * Temporary storage for constructors.
    */
   Map<String, String> constructors = <String, String>{};
 }
 
 /**
  * Create a [GeneratedFile] that creates Java code and outputs it to [path].
  * [path] uses Posix-style path separators regardless of the OS.
  */
 GeneratedFile javaGeneratedFile(String path, CodegenJavaVisitor
     createVisitor(Api api)) {
   return new GeneratedFile(path, () {
     CodegenJavaVisitor visitor = createVisitor(readApi());
     return visitor.collectCode(visitor.visitApi);
   });
 }