Issue 47543010: Issue 14580. Fix for Source in which problem is reported.

Issue 47543010: Issue 14580. Fix for Source in which problem is reported. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 14580. Fix for Source in which problem is reported. https://code.google.com/p/dart/issues/detail?id=14580 Now we correctly report problem in list.dart:331 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29499

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -108 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/EnclosedScope.java	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/LibraryImportScope.java	View	4 chunks	+0 lines, -29 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/LibraryScope.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java	View	4 chunks	+20 lines, -16 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/EnclosedScopeTest.java	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryScopeTest.java	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java	View	5 chunks	+4 lines, -29 lines	0 comments	Download
M	tests/lib/analyzer/analyze_library.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/47543010/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java (right): https://codereview.chromium.org/47543010/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java#newcode169 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Scope.java:169: if (source != null) { Not sure why ...

7 years, 1 month ago (2013-10-29 20:52:00 UTC) #2

scheglov

7 years, 1 month ago (2013-10-29 22:24:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29499 (presubmit successful).

Expand Messages | Collapse Messages