Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java

Issue 47543010: Issue 14580. Fix for Source in which problem is reported. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java
index 5e9d4263ff4f85bd5e1ff8b4aff4c2042886ee3c..52f5ae90a459a8c21baefd7f00bca1e8e4c95b41 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/ScopeTest.java
@@ -20,12 +20,9 @@ import com.google.dart.engine.element.VariableElement;
import com.google.dart.engine.error.AnalysisErrorListener;
import com.google.dart.engine.error.ErrorSeverity;
import com.google.dart.engine.error.GatheringErrorListener;
-import com.google.dart.engine.internal.context.AnalysisContextImpl;
-import com.google.dart.engine.internal.element.LibraryElementImpl;
import com.google.dart.engine.resolver.ResolverTestCase;
import static com.google.dart.engine.ast.ASTFactory.identifier;
-import static com.google.dart.engine.ast.ASTFactory.libraryIdentifier;
import static com.google.dart.engine.element.ElementFactory.localVariableElement;
public class ScopeTest extends ResolverTestCase {
@@ -34,26 +31,15 @@ public class ScopeTest extends ResolverTestCase {
*/
private static class TestScope extends Scope {
/**
- * The element representing the library in which this scope is enclosed.
- */
- private LibraryElement definingLibrary;
-
- /**
* The listener that is to be informed when an error is encountered.
*/
private AnalysisErrorListener errorListener;
- private TestScope(LibraryElement definingLibrary, AnalysisErrorListener errorListener) {
- this.definingLibrary = definingLibrary;
+ private TestScope(AnalysisErrorListener errorListener) {
this.errorListener = errorListener;
}
@Override
- public LibraryElement getDefiningLibrary() {
- return definingLibrary;
- }
-
- @Override
public AnalysisErrorListener getErrorListener() {
return errorListener;
}
@@ -65,9 +51,8 @@ public class ScopeTest extends ResolverTestCase {
}
public void test_define_duplicate() {
- LibraryElement definingLibrary = createTestLibrary();
GatheringErrorListener errorListener = new GatheringErrorListener();
- TestScope scope = new TestScope(definingLibrary, errorListener);
+ TestScope scope = new TestScope(errorListener);
VariableElement element1 = localVariableElement(identifier("v1"));
VariableElement element2 = localVariableElement(identifier("v1"));
scope.define(element1);
@@ -76,9 +61,8 @@ public class ScopeTest extends ResolverTestCase {
}
public void test_define_normal() {
- LibraryElement definingLibrary = createTestLibrary();
GatheringErrorListener errorListener = new GatheringErrorListener();
- TestScope scope = new TestScope(definingLibrary, errorListener);
+ TestScope scope = new TestScope(errorListener);
VariableElement element1 = localVariableElement(identifier("v1"));
VariableElement element2 = localVariableElement(identifier("v2"));
scope.define(element1);
@@ -86,18 +70,9 @@ public class ScopeTest extends ResolverTestCase {
errorListener.assertNoErrors();
}
- public void test_getDefiningLibrary() throws Exception {
- LibraryElement definingLibrary = createTestLibrary();
- TestScope scope = new TestScope(definingLibrary, null);
- assertEquals(definingLibrary, scope.getDefiningLibrary());
- }
-
public void test_getErrorListener() throws Exception {
- LibraryElement definingLibrary = new LibraryElementImpl(
- new AnalysisContextImpl(),
- libraryIdentifier("test"));
GatheringErrorListener errorListener = new GatheringErrorListener();
- TestScope scope = new TestScope(definingLibrary, errorListener);
+ TestScope scope = new TestScope(errorListener);
assertEquals(errorListener, scope.getErrorListener());
}

Powered by Google App Engine
This is Rietveld 408576698