Ignore hidden files in implementation of GeneratedDirectory.check()

Ignore hidden files in implementation of GeneratedDirectory.check()

R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39353

[Paul Berry, 2014-08-18 20:56:41]

lgtm assuming comment is addressed.

https://codereview.chromium.org/469253006/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_tools.dart (right):

https://codereview.chromium.org/469253006/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:418: if(fileSystemEntity is
File && !posix.split(fileSystemEntity.path).last.startsWith('.')) {
Don't use "posix."--this needs to work on Windows.

Also, I think you can replace

  split(fileSystemEntity.path).last

with:

  basename(fileSystemEntity.path)

[jwren, 2014-08-18 21:06:29]

https://codereview.chromium.org/469253006/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_tools.dart (right):

https://codereview.chromium.org/469253006/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:418: if(fileSystemEntity is
File && !posix.split(fileSystemEntity.path).last.startsWith('.')) {
On 2014/08/18 20:56:41, Paul Berry wrote:
> Don't use "posix."--this needs to work on Windows.
> 
> Also, I think you can replace
> 
>   split(fileSystemEntity.path).last
> 
> with:
> 
>   basename(fileSystemEntity.path)

Done.

[jwren, 2014-08-18 21:06:49]

Committed patchset #2 manually as 39353 (presubmit successful).