Ignore hidden files in implementation of GeneratedDirectory.check()

pkg/analysis_server/tool/spec/codegen_tools.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Tools for code generation.
  */
 library codegen.tools;
 
 import 'dart:io';
@@ skipping 393 matching lines @@
     Map<String, FileContentsComputer> map = directoryContentsComputer();
     try {
       map.forEach((String file, FileContentsComputer fileContentsComputer) {
         String expectedContents = fileContentsComputer();
         File outputFile =
             new File(joinAll(posix.split(posix.join(outputDirPath, file))));
         if (expectedContents != outputFile.readAsStringSync()) {
           return false;
         }
       });
-      if (outputFile.listSync().length != map.length) {
+      int nonHiddenFileCount = 0;
+      outputFile.listSync(
+          recursive: false,
+          followLinks: false).forEach((FileSystemEntity fileSystemEntity) {
+         if(fileSystemEntity is File && !posix.split(fileSystemEntity.path).last.startsWith('.')) {

[Paul Berry, 2014/08/18 20:56:41]

Don't use "posix."--this needs to work on Windows.

Also, I think you can replace

  split(fileSystemEntity.path).last

with:

  basename(fileSystemEntity.path)

[jwren, 2014/08/18 21:06:29]

Done.

+           nonHiddenFileCount++;
+         }
+      });
+      if (nonHiddenFileCount != map.length) {
         // The number of files generated doesn't match the number we expected to
         // generate.
         return false;
       }
     } catch (e) {
       // There was a problem reading the file (most likely because it didn't
       // exist).  Treat that the same as if the file doesn't have the expected
       // contents.
       return false;
     }
@@ skipping 18 matching lines @@
     outputFile.createSync(recursive: true);
 
     // generate all of the files in the directory
     Map<String, FileContentsComputer> map = directoryContentsComputer();
     map.forEach((String file, FileContentsComputer fileContentsComputer) {
       File outputFile = new File(joinAll(posix.split(outputDirPath + file)));
       outputFile.writeAsStringSync(fileContentsComputer());
     });
   }
 }