Issue 46893004: - Force errors when using bad types or overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 46893004: - Force errors when using bad types or overrides. (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Force errors when using bad types or overrides. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29821

Patch Set 3 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -18 lines)			Patch
	M	runtime/lib/mirrors_impl.dart	View	1 2	3 chunks	+5 lines, -17 lines	0 comments	Download
	M	tests/language/hello_dart_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/46893004/diff/30001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/46893004/diff/30001/runtime/lib/mirrors_impl.dart#newcode1255 runtime/lib/mirrors_impl.dart:1255: throw /* new MirrorException */( Should this be ...

7 years, 1 month ago (2013-11-04 16:32:20 UTC) #2

Ivan Posva

7 years, 1 month ago (2013-11-04 17:26:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r29821 (presubmit successful).

Expand Messages | Collapse Messages

Issue 46893004: - Force errors when using bad types or overrides. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages