- Force errors when using bad types or overrides.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 import "dart:collection";
 
 final emptyList = new UnmodifiableListView([]);
 final emptyMap = new _UnmodifiableMapView({});
@@ skipping 31 matching lines @@
 
   V putIfAbsent(K key, V ifAbsent()) { _throw(); }
 
   void addAll(Map<K, V> other) => _throw();
 
   V remove(K key) { _throw(); }
 
   void clear() => _throw();
 }
 
-// These values are allowed to be passed directly over the wire.
-bool _isSimpleValue(var value) {
-  return (value == null || value is num || value is String || value is bool);
+class _InternalMirrorError {
+  const _InternalError(String this._msg);
+  String toString() => _msg;
+  final String _msg;
 }
 
 Map _filterMap(Map<Symbol, dynamic> old_map, bool filter(Symbol key, value)) {
   Map new_map = new Map<Symbol, dynamic>();
   old_map.forEach((key, value) {
     if (filter(key, value)) {
       new_map[key] = value;
     }
   });
   return new _UnmodifiableMapView(new_map);
@@ skipping 144 matching lines @@
     return reflect(this._invokeGetter(_reflectee,
                                       _n(memberName)));
   }
 
   InstanceMirror setField(Symbol memberName, Object value) {
     this._invokeSetter(_reflectee,
                        _n(memberName),
                        value);
     return reflect(value);
   }
-
-  static _validateArgument(int i, Object arg)
-  {
-    if (arg is Mirror) {
-        if (arg is! InstanceMirror) {
-          throw new MirrorException(
-              'positional argument $i ($arg) was not an InstanceMirror');
-        }
-      } else if (!_isSimpleValue(arg)) {
-        throw new MirrorException(
-            'positional argument $i ($arg) was not a simple value');
-      }
-  }
 }
 
 class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
     implements InstanceMirror {
   // TODO(ahe): This is a hack, see delegate below.
   static Function _invokeOnClosure;
 
   _LocalInstanceMirrorImpl(reflectee) : super(reflectee);
 
   ClassMirror _type;
@@ skipping 1003 matching lines @@
   bool get isRegularMethod => !isGetter && !isSetter && !isConstructor;
 
   Symbol _constructorName = null;
   Symbol get constructorName {
     if (_constructorName == null) {
       if (!isConstructor) {
         _constructorName = _s('');
       } else {
         var parts = MirrorSystem.getName(simpleName).split('.');
         if (parts.length > 2) {
-          throw new MirrorException(
+          throw new _InternalMirrorError(
               'Internal error in MethodMirror.constructorName: '
               'malformed name <$simpleName>');
         } else if (parts.length == 2) {
           _constructorName = _s(parts[1]);
         } else {
           _constructorName = _s('');
         }
       }
     }
     return _constructorName;
@@ skipping 214 matching lines @@
     if (typeMirror == null) {
       typeMirror = makeLocalTypeMirror(key);
       _instanitationCache[key] = typeMirror;
       if (typeMirror is ClassMirror && !typeMirror._isGeneric) {
         _declarationCache[key] = typeMirror;
       }
     }
     return typeMirror;
   }
 }