Issue 467623002: Don't inherit metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 467623002: Don't inherit metadata. (Closed)

Created:
6 years, 4 months ago by floitsch

Modified:
6 years, 4 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't inherit metadata. BUG= http://dartbug.com/20461 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=39129

Patch Set 2 : Update copyright year. #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -1 line)			Patch
	M	sdk/lib/_internal/lib/js_mirrors.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	A	tests/lib/mirrors/inherited_metadata_test.dart	View	1	1 chunk	+52 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

Still need to run all tests locally, but I hope that the change didn't break ...

6 years, 4 months ago (2014-08-12 12:11:25 UTC) #1

karlklose

LGTM. https://codereview.chromium.org/467623002/diff/20001/tests/lib/mirrors/inherited_metadata_test.dart File tests/lib/mirrors/inherited_metadata_test.dart (right): https://codereview.chromium.org/467623002/diff/20001/tests/lib/mirrors/inherited_metadata_test.dart#newcode36 tests/lib/mirrors/inherited_metadata_test.dart:36: ClassMirror cm = d as ClassMirror; You should ...

6 years, 4 months ago (2014-08-12 12:22:34 UTC) #2

floitsch

6 years, 4 months ago (2014-08-12 13:04:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 39129 (presubmit successful).

Expand Messages | Collapse Messages

Issue 467623002: Don't inherit metadata. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Update copyright year. #

Messages