sdk/lib/_internal/lib/js_mirrors.dart - Issue 467623002: Don't inherit metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 467623002: Don't inherit metadata. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update copyright year. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index 6bdd46e8035095c94e33e41aedee59c85502cf17..c54dc57cb3d3f28492c5eaa7170b8219b2b39a80 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -2759,7 +2759,10 @@ Symbol computeQualifiedName(DeclarationMirror owner, Symbol simpleName) {

List extractMetadata(victim) {

preserveMetadata();

- var metadataFunction = JS('', '#["@"]', victim);

+ var metadataFunction;

+ if (JS('bool', 'Object.prototype.hasOwnProperty.call(#, "@")', victim)) {

+ metadataFunction = JS('', '#["@"]', victim);

+ }

if (metadataFunction != null) return JS('', '#()', metadataFunction);

if (JS('bool', 'typeof # != "function"', victim)) return const [];

if (JS('bool', '# in #', r'$metadataIndex', victim)) {