Use function names as service IDs, rather than indices.

Use function names as service IDs, rather than indices.

This gives more descriptive ids and removes dependency on implementation details of Class.

Special kinds of functions still use indices and oddballs still fall back to the object ring.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39217

[Cutch, 2014-08-13 18:01:47]

lgtm

https://codereview.chromium.org/466183002/diff/60001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/466183002/diff/60001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1150: PrintError(js, "Function %s not found",
id.ToCString());
Should we report the undecoded id (so that it matches whatever URL was used to
make the request?). Not sure what is best. If you do decide to report the
undecoded ID you might need to change the error we return for script requests.

[koda, 2014-08-13 18:18:35]

https://codereview.chromium.org/466183002/diff/60001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/466183002/diff/60001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1150: PrintError(js, "Function %s not found",
id.ToCString());
On 2014/08/13 18:01:47, Cutch wrote:
> Should we report the undecoded id (so that it matches whatever URL was used to
> make the request?). Not sure what is best. If you do decide to report the
> undecoded ID you might need to change the error we return for script requests.

Good idea; changed to report the id from the request.

Also added an error for a malformed id (invalid IRI).

[koda, 2014-08-13 19:59:23]

Committed patchset #5 manually as r39217 (presubmit successful).