Use function names as service IDs, rather than indices.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1121 matching lines @@
 static bool HandleClassesFunctionsCoverage(
     Isolate* isolate, const Function& func, JSONStream* js) {
   FunctionCoverageFilter filter(func);
   CodeCoverage::PrintJSON(isolate, js, &filter);
   return true;
 }
 
 
 static bool HandleClassesFunctions(Isolate* isolate, const Class& cls,
                                    JSONStream* js) {
-  intptr_t id;
-  if (js->num_arguments() > 5) {
-    PrintError(js, "Command too long");
+  if (js->num_arguments() != 4 && js->num_arguments() != 5) {
+    PrintError(js, "Command should have 4 or 5 arguments");
     return true;
   }
-  if (!GetIntegerId(js->GetArgument(3), &id)) {
-    PrintError(js, "Must specify collection object id: functions/id");
+  const char* encoded_id = js->GetArgument(3);
+  String& id = String::Handle(isolate, String::New(encoded_id));
+  id = String::DecodeIRI(id);
+  if (id.IsNull()) {
+    PrintError(js, "Function id %s is malformed", encoded_id);
     return true;
   }
-  Function& func = Function::Handle();
-  func ^= cls.FunctionFromIndex(id);
+  Function& func = Function::Handle(cls.LookupFunction(id));
   if (func.IsNull()) {
-    PrintError(js, "Function %" Pd " not found", id);
+    PrintError(js, "Function %s not found", encoded_id);
     return true;
   }
   if (js->num_arguments() == 4) {
     func.PrintJSON(js, false);
     return true;
   } else {
     const char* subcollection = js->GetArgument(4);
     if (strcmp(subcollection, "coverage") == 0) {
       return HandleClassesFunctionsCoverage(isolate, func, js);
     } else {
@@ skipping 1359 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart