Issue 465903002: Work around AppCache issues to switch to SSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 465903002: Work around AppCache issues to switch to SSL. (Closed)

Created:
6 years, 4 months ago by ahe

Modified:
6 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Johnni Winther, lukechurch, sethladd

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Work around AppCache issues to switch to SSL. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=39127

Patch Set 1 : Currently live as version r38982 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -33 lines)			Patch
M	dart/site/try/app.yaml	View	1	2 chunks	+30 lines, -5 lines	1 comment	Download
M	dart/site/try/build_try.gyp	View		3 chunks	+26 lines, -1 line	0 comments	Download
M	dart/site/try/index.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/site/try/nossl.appcache	View		1 chunk	+3 lines, -16 lines	0 comments	Download
A +	dart/site/try/nossl.html	View		1 chunk	+6 lines, -5 lines	0 comments	Download
A	dart/site/try/nossl.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	dart/site/try/ssl.appcache	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/465903002/diff/20001/dart/site/try/app.yaml File dart/site/try/app.yaml (right): https://codereview.chromium.org/465903002/diff/20001/dart/site/try/app.yaml#newcode108 dart/site/try/app.yaml:108: # manifest (nossl.appcache) and the files listed in ...

6 years, 4 months ago (2014-08-12 08:15:42 UTC) #2

ahe

6 years, 4 months ago (2014-08-12 11:09:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 39127 (presubmit successful).

Expand Messages | Collapse Messages