Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: dart/site/try/app.yaml

Issue 465903002: Work around AppCache issues to switch to SSL. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/site/try/build_try.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/site/try/app.yaml
diff --git a/dart/site/try/app.yaml b/dart/site/try/app.yaml
index bcd77778cbbbb0f97a2f6667221d566ff9829a42..e8044ff5dcee14ac601f352e5e188120978bf7ba 100644
--- a/dart/site/try/app.yaml
+++ b/dart/site/try/app.yaml
@@ -102,9 +102,39 @@ handlers:
upload: index.html
secure: always
+# The nossl file below help work around bugs/features in interaction between
+# AppEngine and AppCache. When a return user goes to http://try.dartlang.org/
+# (no SSL), AppCache will serve index.html from cache, try to fetch the old
+# manifest (nossl.appcache) and the files listed in the manifest. In additation
kasperl 2014/08/12 08:15:42 additation -> addition to
+# the files listed in the manifest, it will also fetch index.html, as it is the
+# master. However, we want index.html to be redirected to the SSL version, and
+# AppCache sees this redirection as a network error. When an error occurs,
+# AppCache will keep serving the old page. So we configure nossl.appcache to
+# provide fallbacks for index.html and leap.dart.js. The fallback for
+# leap.dart.js is nossl.js which will take care of redirecting to
+# https://try.dartlang.org/ (with SSL) using JavaScript. Unfortunately, Chrome
+# seems to keep the old version of index.html cached indefinitely. The only way
+# to avoid that appears to serve up a different index.html depending on if it
+# is a secure connection or not. This would require a Python script, and
+# something we may consider implementing in the future.
- url: /nossl.appcache
static_files: nossl.appcache
upload: nossl.appcache
+ secure: optional
+
+- url: /nossl.js
+ static_files: nossl.js
+ upload: nossl.js
+ secure: optional
+
+- url: /nossl.html
+ static_files: nossl.html
+ upload: nossl.html
+ secure: optional
+
+- url: /ssl.appcache
+ static_files: ssl.appcache
+ upload: ssl.appcache
secure: always
- url: /(.*\.(html|js|png|css|dart|json))
@@ -117,11 +147,6 @@ handlers:
upload: fontawesome-webfont.woff
secure: always
-- url: .*
- static_files: not_found.html
- upload: not_found.html
- secure: always
-
libraries:
- name: webapp2
version: "2.5.2"
« no previous file with comments | « no previous file | dart/site/try/build_try.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698