Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 465343002: Fix type propagation for signature classes. (Closed)

Created:
6 years, 4 months ago by Florian Schneider
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix type propagation for signature classes. After I enabled nullability tracking for checked mode type assertions, we need to fix type propagation for signature classes: We can't use the asserted type to infer a cid for those since it may cause unnecessary deoptimizations. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
This fixes the repeated deoptimization in checked mode.
6 years, 4 months ago (2014-08-13 13:26:05 UTC) #1
Vyacheslav Egorov (Google)
I wonder if we want to assert in the IsImplemented() that we don't pass signature ...
6 years, 4 months ago (2014-08-13 13:27:28 UTC) #2
Florian Schneider
6 years, 4 months ago (2014-08-13 13:45:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698