Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 465343002: Fix type propagation for signature classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 39194)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -511,7 +511,10 @@
if (FLAG_use_cha) {
const Class& type_class = Class::Handle(type_->type_class());
CHA* cha = Isolate::Current()->cha();
- if (!cha->IsImplemented(type_class) &&
+ // Don't infer a cid for signature classes since there can be multiple
+ // signature classes that are assignable to each other.
+ if (!type_class.IsSignatureClass() &&
+ !cha->IsImplemented(type_class) &&
!cha->HasSubclasses(type_class.id())) {
cid_ = type_class.id();
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698