Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 463993002: - Separate the thread implementation used in bin/ and vm/ (Closed)

Created:
6 years, 4 months ago by Ivan Posva
Modified:
6 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Separate the thread implementation used in bin/ and vm/ to allow us to make VM specific changes.

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1982 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 2 chunks +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection_macos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/dbg_message.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/file.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/io_service.cc View 1 chunk +1 line, -2 lines 2 comments Download
A + runtime/bin/lockers.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/process.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/process_android.cc View 1 chunk +1 line, -0 lines 4 comments Download
M runtime/bin/process_linux.cc View 1 chunk +1 line, -0 lines 2 comments Download
M runtime/bin/process_macos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/process_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/socket.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/stdio.cc View 1 chunk +0 lines, -1 line 0 comments Download
R + runtime/bin/thread.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + runtime/bin/thread_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/thread_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/thread_linux.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/thread_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/thread_macos.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/bin/thread_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/bin/thread_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +1 line, -1 line 0 comments Download
M runtime/platform/platform_sources.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/platform/signal_blocker.h View 1 chunk +0 lines, -2 lines 0 comments Download
D runtime/platform/thread.h View 1 chunk +0 lines, -101 lines 0 comments Download
D runtime/platform/thread_android.h View 1 chunk +0 lines, -75 lines 0 comments Download
D runtime/platform/thread_android.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D runtime/platform/thread_linux.h View 1 chunk +0 lines, -75 lines 0 comments Download
D runtime/platform/thread_linux.cc View 1 chunk +0 lines, -330 lines 0 comments Download
D runtime/platform/thread_macos.h View 1 chunk +0 lines, -75 lines 0 comments Download
D runtime/platform/thread_macos.cc View 1 chunk +0 lines, -335 lines 0 comments Download
D runtime/platform/thread_win.h View 1 chunk +0 lines, -121 lines 0 comments Download
D runtime/platform/thread_win.cc View 1 chunk +0 lines, -439 lines 0 comments Download
M runtime/vm/code_observers.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/cpu_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/cpu_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_state.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +1 line, -1 line 0 comments Download
A + runtime/vm/lockers.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/message.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/message_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/message_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/native_message_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_symbol_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_symbol_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_symbol_macos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/native_symbol_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/port.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/port_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/profiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/scanner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
R + runtime/vm/thread.h View 2 chunks +8 lines, -7 lines 0 comments Download
A + runtime/vm/thread_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/vm/thread_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/vm/thread_interrupter.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + runtime/vm/thread_linux.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/vm/thread_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/vm/thread_macos.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/vm/thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_pool.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/thread_pool.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/thread_pool_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/vm/thread_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/vm/thread_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
6 years, 4 months ago (2014-08-12 20:49:54 UTC) #1
siva
lgtm https://codereview.chromium.org/463993002/diff/1/runtime/bin/io_service.cc File runtime/bin/io_service.cc (right): https://codereview.chromium.org/463993002/diff/1/runtime/bin/io_service.cc#newcode14 runtime/bin/io_service.cc:14: extra blank line? https://codereview.chromium.org/463993002/diff/1/runtime/bin/process_android.cc File runtime/bin/process_android.cc (right): https://codereview.chromium.org/463993002/diff/1/runtime/bin/process_android.cc#newcode20 ...
6 years, 4 months ago (2014-08-12 21:01:29 UTC) #2
Ivan Posva
Thanks! -Ivan https://codereview.chromium.org/463993002/diff/1/runtime/bin/io_service.cc File runtime/bin/io_service.cc (right): https://codereview.chromium.org/463993002/diff/1/runtime/bin/io_service.cc#newcode14 runtime/bin/io_service.cc:14: On 2014/08/12 21:01:28, siva wrote: > extra ...
6 years, 4 months ago (2014-08-12 23:20:47 UTC) #3
Ivan Posva
6 years, 4 months ago (2014-08-12 23:20:48 UTC) #4
Committed patchset #1 manually as r39172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698