- Separate the thread implementation used in bin/ and vm/

runtime/bin/process_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/process.h"
 
 #include <errno.h>  // NOLINT
 #include <fcntl.h>  // NOLINT
 #include <poll.h>  // NOLINT
 #include <stdio.h>  // NOLINT
 #include <stdlib.h>  // NOLINT
 #include <string.h>  // NOLINT
 #include <sys/wait.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 
 #include "bin/fdutils.h"
+#include "bin/lockers.h"

[siva, 2014/08/12 21:01:28]

included in bin/process.h already so not needed here?

[Ivan Posva, 2014/08/12 23:20:46]

Acknowledged.

 #include "bin/log.h"
 #include "bin/thread.h"

[siva, 2014/08/12 21:01:28]

Ditto comment about bin/thread.h

[Ivan Posva, 2014/08/12 23:20:46]

Acknowledged.

 
 #include "platform/signal_blocker.h"
 
 
 extern char **environ;
 
 
 namespace dart {
 namespace bin {
 
@@ skipping 708 matching lines @@
     bzero(&act, sizeof(act));
     act.sa_handler = SIG_DFL;
     VOID_NO_RETRY_EXPECTED(sigaction(signal, &act, NULL));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)