Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 463643002: Add an integration test for analysis.highlights. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an integration test for analysis.highlights. Also fix sort order in the API definition of HighlightRegionType. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39152

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -13 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_server/test/integration/analysis/highlights_test.dart View 1 chunk +134 lines, -0 lines 5 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
Brian-- I wasn't able to figure out how to get all of the possible highlight ...
6 years, 4 months ago (2014-08-11 21:11:19 UTC) #1
scheglov
https://codereview.chromium.org/454843004/ will fix most of these TODO problems. https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/test/integration/analysis/highlights_test.dart File pkg/analysis_server/test/integration/analysis/highlights_test.dart (right): https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/test/integration/analysis/highlights_test.dart#newcode98 pkg/analysis_server/test/integration/analysis/highlights_test.dart:98: // ...
6 years, 4 months ago (2014-08-12 02:28:47 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode8 pkg/analysis_server/tool/spec/spec_input.html:8: <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1> Do we ...
6 years, 4 months ago (2014-08-12 13:29:14 UTC) #3
Paul Berry
https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/463643002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode8 pkg/analysis_server/tool/spec/spec_input.html:8: <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1> On 2014/08/12 13:29:14, ...
6 years, 4 months ago (2014-08-12 17:40:02 UTC) #4
Paul Berry
6 years, 4 months ago (2014-08-12 18:16:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r39152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698