Add missing coverage for generics properties of dynamic and void. Fix reflectType(dynamic) in dart2…

Add missing coverage for generics properties of dynamic and void. Fix reflectType(dynamic) in dart2js.

R=ahe@google.com, gbracha@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29455

[gbracha, 2013-10-29 02:31:00]

tests lgtm

[Johnni Winther, 2013-10-29 04:19:40]

lgtm

[ahe, 2013-10-29 09:34:37]

Thank you, Ryan!

LGTM

https://codereview.chromium.org/46303004/diff/40001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/46303004/diff/40001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:39: final emptyList = new
UnmodifiableListView([]);
This generates horrible code in dart2js because the right-hand side isn't a
constant. Consequently, this field is initialized lazily which leads to crappy
code.

Also, it doesn't contain type information.

My preference is to return "const <TYPE>[]" whenever emptyList is used.

[rmacnak, 2013-10-29 16:34:39]

On 2013/10/29 09:34:37, ahe wrote:
> Thank you, Ryan!
> 
> LGTM
> 
>
https://codereview.chromium.org/46303004/diff/40001/sdk/lib/_internal/lib/js_...
> File sdk/lib/_internal/lib/js_mirrors.dart (right):
> 
>
https://codereview.chromium.org/46303004/diff/40001/sdk/lib/_internal/lib/js_...
> sdk/lib/_internal/lib/js_mirrors.dart:39: final emptyList = new
> UnmodifiableListView([]);
> This generates horrible code in dart2js because the right-hand side isn't a
> constant. Consequently, this field is initialized lazily which leads to crappy
> code.
> 
> Also, it doesn't contain type information.
> 
> My preference is to return "const <TYPE>[]" whenever emptyList is used.

Done.  (I thought I tried typed const collections in another CL a month or two
ago and had the compilers reject it, but it works now.)

[rmacnak, 2013-10-29 16:35:43]

Committed patchset #3 manually as r29455 (presubmit successful).