Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 46303004: Add missing coverage for generics properties of dynamic and void. Fix reflectType(dynamic) in dart2… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/mirrors_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index f6f521d524500d01411df71a547ba077ada94bd1..610af50a5b7ee7c5228df234cf1a78f39488c577 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -229,8 +229,8 @@ class JsTypeMirror extends JsDeclarationMirror implements TypeMirror {
bool get hasReflectedType => false;
Type get reflectedType => throw new UnsupportedError("This type does not support reflectedTypees");
- List<TypeVariableMirror> get typeVariables => throw new UnimplementedError();
- List<TypeMirror> get typeArguments => throw new UnimplementedError();
+ List<TypeVariableMirror> get typeVariables => const <TypeVariableMirror>[];
+ List<TypeMirror> get typeArguments => const <TypeMirror>[];
bool get isOriginalDeclaration => true;
TypeMirror get originalDeclaration => this;
@@ -689,7 +689,7 @@ class JsMixinApplication extends JsTypeMirror with JsObjectMirror
throw new UnimplementedError();
}
- List<TypeMirror> get typeArguments => new List();
+ List<TypeMirror> get typeArguments => const <TypeMirror>[];
}
abstract class JsObjectMirror implements ObjectMirror {
@@ -1422,7 +1422,7 @@ class JsClassMirror extends JsTypeMirror with JsObjectMirror
return _cachedTypeVariables = new UnmodifiableListView(result);
}
- List<TypeMirror> get typeArguments => new List();
+ List<TypeMirror> get typeArguments => const <TypeMirror>[];
}
class JsVariableMirror extends JsDeclarationMirror implements VariableMirror {
« no previous file with comments | « no previous file | sdk/lib/_internal/lib/mirrors_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698