Change how we check for user agent, in preparation for breaking change in Dartium.

Change how we check for user agent, in preparation for breaking change in Dartium.

R=jakemac@google.com, vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39204

[vsm, 2014-08-13 06:34:21]

lgtm

[kasperl, 2014-08-13 07:29:34]

DBQ

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js
File pkg/polymer/lib/boot.js (right):

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js#newc...
pkg/polymer/lib/boot.js:36: if (!navigator.dartEnabled &&
Will we be able to simplify this and get rid of the indexOf check in the future
(once everybody has the new Dartium with navigator.dartEnabled)?

https://codereview.chromium.org/462333002/diff/1/pkg/web_components/lib/dart_...
File pkg/web_components/lib/dart_support.js (right):

https://codereview.chromium.org/462333002/diff/1/pkg/web_components/lib/dart_...
pkg/web_components/lib/dart_support.js:10: if (navigator.dartEnabled ||
(navigator.userAgent.indexOf('(Dart)') !== -1)) {
Same question.

[vsm, 2014-08-13 08:24:06]

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js
File pkg/polymer/lib/boot.js (right):

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js#newc...
pkg/polymer/lib/boot.js:36: if (!navigator.dartEnabled &&
Yes - this is just precautionary for the transition.  Siggi: can you add a
comment here to that effect similar to

https://codereview.chromium.org/463083002/diff/20001/pkg/browser/lib/dart.js

?

On 2014/08/13 07:29:33, kasperl wrote:
> Will we be able to simplify this and get rid of the indexOf check in the
future
> (once everybody has the new Dartium with navigator.dartEnabled)?

[jakemac, 2014-08-13 14:57:34]

lgtm

[Siggi Cherem (dart-lang), 2014-08-13 16:15:27]

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js
File pkg/polymer/lib/boot.js (right):

https://codereview.chromium.org/462333002/diff/1/pkg/polymer/lib/boot.js#newc...
pkg/polymer/lib/boot.js:36: if (!navigator.dartEnabled &&
On 2014/08/13 08:24:06, vsm wrote:
> Yes - this is just precautionary for the transition.  Siggi: can you add a
> comment here to that effect similar to
> 
> https://codereview.chromium.org/463083002/diff/20001/pkg/browser/lib/dart.js
> 
> ?
> 
> On 2014/08/13 07:29:33, kasperl wrote:
> > Will we be able to simplify this and get rid of the indexOf check in the
> future
> > (once everybody has the new Dartium with navigator.dartEnabled)?
> 

Done.

[Siggi Cherem (dart-lang), 2014-08-13 16:16:33]

Committed patchset #4 manually as 39204 (presubmit successful).