pkg/web_components/lib/dart_support.js - Issue 462333002: Change how we check for user agent, in preparation for breaking change in Dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/web_components/lib/dart_support.js

Issue 462333002: Change how we check for user agent, in preparation for breaking change in Dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/web_components/lib/dart_support.js

diff --git a/pkg/web_components/lib/dart_support.js b/pkg/web_components/lib/dart_support.js

index efa130106068a64608998a29152adb148a7f5d8e..7ce882cef9a107d18d5fc8ec23de4d7df69673d8 100644

--- a/pkg/web_components/lib/dart_support.js

+++ b/pkg/web_components/lib/dart_support.js

@@ -7,7 +7,9 @@

var ShadowDOMPolyfill = window.ShadowDOMPolyfill;

if (!ShadowDOMPolyfill) return;

- if (navigator.userAgent.indexOf('(Dart)') !== -1) {

+ // TODO(sigmund): remove the userAgent check once 1.6 rolls as stable.

+ // See: dartbug.com/18463

+ if (navigator.dartEnabled || (navigator.userAgent.indexOf('(Dart)') !== -1)) {

console.error("ShadowDOMPolyfill polyfill was loaded in Dartium. This " +

"will not work. This indicates that Dartium's Chrome version is " +

"not compatible with this version of web_components.");

« no previous file with comments | « pkg/web_components/CHANGELOG.md ('k') | pkg/web_components/pubspec.yaml » ('j') | no next file with comments »