Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 46163002: Bugfix in test.dart, adding of specialized test outcomes for analyzer (Closed)

Created:
7 years, 1 month ago by kustermann
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bugfix in test.dart, adding of specialized test outcomes for analyzer This CL will: - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases we did not report that the analyzer was missing a warning). - make the outcome of running the analyzer on a test be one of: * CompileTimeError * MissingCompileTimeError * StaticWarning * MissingStaticWarning - Make status file updates using the new Expectation markers - Remove support for '@static-clean': Previously running the analyer on a test could either result in 'Pass' or in 'Fail'. The '@static-clean' annotation has been used as a (poor) mechanism to distinguish between errors and warnings. Having the 4 markers mentioned above means we can remove '@static-clean' - Remove 100 lines of rotted legacy code in our testing scripts. - Make a status file entry for every test that has analyzer errors or warnings R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29350

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -312 lines) Patch
M dart/pkg/custom_element/test/analyzer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/pkg/observe/test/observe_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/pkg/pkg.status View 1 chunk +109 lines, -0 lines 0 comments Download
M dart/pkg/template_binding/test/analyzer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/runtime/tests/vm/vm.status View 1 chunk +5 lines, -0 lines 0 comments Download
M dart/samples/build_dart/test/build_dart_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/build_dart_simple/test/build_dart_simple_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/clock/test/clock_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/samples.status View 1 chunk +12 lines, -0 lines 0 comments Download
M dart/samples/solar/test/solar_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/sunflower/test/sunflower_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/swipe/test/swipe_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/samples/time/test/time_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-analyzer.status View 1 chunk +44 lines, -0 lines 0 comments Download
M dart/tests/co19/co19-analyzer2.status View 1 chunk +44 lines, -0 lines 0 comments Download
M dart/tests/corelib/corelib.status View 1 chunk +11 lines, -0 lines 0 comments Download
M dart/tests/html/html.status View 1 chunk +19 lines, -0 lines 0 comments Download
M dart/tests/isolate/isolate.status View 2 chunks +8 lines, -7 lines 0 comments Download
M dart/tests/language/arithmetic2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/bool_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/tests/language/context2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/default_implementation_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/language/dynamic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/getters_setters_type2_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/getters_setters_type3_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/language.status View 1 chunk +298 lines, -0 lines 0 comments Download
M dart/tests/language/part_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/language/third_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
D dart/tests/lib/analyzer/analyze_tests.status View 1 chunk +0 lines, -64 lines 0 comments Download
M dart/tests/lib/analyzer/test_config.dart View 2 chunks +1 line, -18 lines 0 comments Download
M dart/tests/lib/lib.status View 1 chunk +50 lines, -0 lines 0 comments Download
M dart/tests/standalone/standalone.status View 1 chunk +13 lines, -0 lines 0 comments Download
M dart/tests/utils/dart2js_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M dart/tests/utils/utils.status View 1 chunk +4 lines, -0 lines 0 comments Download
M dart/tools/test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/tools/testing/dart/multitest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tools/testing/dart/status_file_parser.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M dart/tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tools/testing/dart/test_runner.dart View 1 3 chunks +60 lines, -138 lines 2 comments Download
M dart/tools/testing/dart/test_suite.dart View 13 chunks +10 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 1 month ago (2013-10-25 23:43:00 UTC) #1
ricow1
LGTM Editor people: Could you triage all the lines in the status files? https://codereview.chromium.org/46163002/diff/140001/dart/tools/testing/dart/test_runner.dart File ...
7 years, 1 month ago (2013-10-28 07:19:04 UTC) #2
kustermann
Committed patchset #2 manually as r29350 (presubmit successful).
7 years, 1 month ago (2013-10-28 10:40:07 UTC) #3
kustermann
7 years, 1 month ago (2013-10-28 11:55:13 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/46163002/diff/140001/dart/tools/testing/dart/...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/46163002/diff/140001/dart/tools/testing/dart/...
dart/tools/testing/dart/test_runner.dart:947: List<String> errors = [], warnings
= [];
On 2013/10/28 07:19:05, ricow1 wrote:
> one on each line please

Done.

Powered by Google App Engine
This is Rietveld 408576698