dart/tools/testing/dart/multitest.dart - Issue 46163002: Bugfix in test.dart, adding of specialized test outcomes for analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/dart/multitest.dart

Issue 46163002: Bugfix in test.dart, adding of specialized test outcomes for analyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/testing/dart/multitest.dart

diff --git a/dart/tools/testing/dart/multitest.dart b/dart/tools/testing/dart/multitest.dart

index b9424375e39685f30273db3e30a6b6e63c9dd5ea..197e850f5bca934edc90b1aa650807c42a4cdeef 100644

--- a/dart/tools/testing/dart/multitest.dart

+++ b/dart/tools/testing/dart/multitest.dart

@@ -229,7 +229,7 @@ Future doMultitest(Path filePath, String outputDir, Path suiteDir,

openedFile.writeStringSync(tests[key]);

openedFile.closeSync();

Set<String> outcome = outcomes[key];

- bool enableFatalTypeErrors = outcome.contains('static type warning');

+ bool hasStaticWarning = outcome.contains('static type warning');

bool hasRuntimeErrors = outcome.contains('runtime error');

bool hasCompileError = outcome.contains('compile-time error');

bool isNegativeIfChecked = outcome.contains('dynamic type error');

@@ -237,7 +237,7 @@ Future doMultitest(Path filePath, String outputDir, Path suiteDir,

hasCompileError,

hasRuntimeErrors,

isNegativeIfChecked: isNegativeIfChecked,

- hasFatalTypeErrors: enableFatalTypeErrors,

+ hasStaticWarning: hasStaticWarning,

multitestOutcome: outcome,

multitestKey: key,

originTestPath: filePath);

« no previous file with comments | « dart/tools/test.dart ('k') | dart/tools/testing/dart/status_file_parser.dart » ('j') | dart/tools/testing/dart/test_runner.dart » ('J')