Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 46143004: Added helpful information on all event getters and static members. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski
Modified:
7 years, 1 month ago
Reviewers:
blois
CC:
reviews_dartlang.org, Kathy Walrath
Visibility:
Public.

Description

Added helpful information on all event getters and static members. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29755

Patch Set 1 #

Patch Set 2 : Made event names all lowercase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7709 lines, -283 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 90 chunks +1657 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 91 chunks +1645 lines, -4 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 7 chunks +77 lines, -0 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 7 chunks +77 lines, -0 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 chunks +294 lines, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 chunks +294 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 8 chunks +29 lines, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 8 chunks +29 lines, -1 line 0 comments Download
M tools/dom/docs/docs.json View 1 6 chunks +3582 lines, -271 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 chunks +12 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
7 years, 1 month ago (2013-10-31 20:33:36 UTC) #1
blois
lgtm
7 years, 1 month ago (2013-11-01 16:21:10 UTC) #2
Andrei Mouravski
7 years, 1 month ago (2013-11-01 16:59:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698