Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

Issue 46143004: Added helpful information on all event getters and static members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Made event names all lowercase. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/svg/dartium/svg_dartium.dart ('k') | sdk/lib/web_audio/dartium/web_audio_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
diff --git a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
index 2caaa6457617b012d2602c3dbfadfd5fe21abbc6..4556a9015aeaddc954e3db8ca7e574fb01f68e00 100644
--- a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
+++ b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
@@ -154,6 +154,12 @@ class AudioBufferSourceNode extends AudioSourceNode native "AudioBufferSourceNod
// To suppress missing implicit constructor warnings.
factory AudioBufferSourceNode._() { throw new UnsupportedError("Not supported"); }
+ /**
+ * Static factory designed to expose `ended` events to event
+ * handlers that are not necessarily instances of [AudioBufferSourceNode].
+ *
+ * See [EventStreamProvider] for usage information.
+ */
@DomName('AudioBufferSourceNode.endedEvent')
@DocsEditable()
@Experimental() // untriaged
@@ -215,6 +221,7 @@ class AudioBufferSourceNode extends AudioSourceNode native "AudioBufferSourceNod
@DocsEditable()
void noteOn(num when) native;
+ /// Stream of `ended` events handled by this [AudioBufferSourceNode].
@DomName('AudioBufferSourceNode.onended')
@DocsEditable()
@Experimental() // untriaged
@@ -233,6 +240,12 @@ class AudioContext extends EventTarget native "AudioContext,webkitAudioContext"
// To suppress missing implicit constructor warnings.
factory AudioContext._() { throw new UnsupportedError("Not supported"); }
+ /**
+ * Static factory designed to expose `complete` events to event
+ * handlers that are not necessarily instances of [AudioContext].
+ *
+ * See [EventStreamProvider] for usage information.
+ */
@DomName('AudioContext.completeEvent')
@DocsEditable()
static const EventStreamProvider<Event> completeEvent = const EventStreamProvider<Event>('complete');
@@ -362,6 +375,7 @@ class AudioContext extends EventTarget native "AudioContext,webkitAudioContext"
@DocsEditable()
void startRendering() native;
+ /// Stream of `complete` events handled by this [AudioContext].
@DomName('AudioContext.oncomplete')
@DocsEditable()
Stream<Event> get onComplete => completeEvent.forTarget(this);
@@ -884,6 +898,12 @@ class OscillatorNode extends AudioSourceNode native "OscillatorNode,Oscillator"
// To suppress missing implicit constructor warnings.
factory OscillatorNode._() { throw new UnsupportedError("Not supported"); }
+ /**
+ * Static factory designed to expose `ended` events to event
+ * handlers that are not necessarily instances of [OscillatorNode].
+ *
+ * See [EventStreamProvider] for usage information.
+ */
@DomName('OscillatorNode.endedEvent')
@DocsEditable()
@Experimental() // untriaged
@@ -942,6 +962,7 @@ class OscillatorNode extends AudioSourceNode native "OscillatorNode,Oscillator"
@DocsEditable()
void stop(num when) native;
+ /// Stream of `ended` events handled by this [OscillatorNode].
@DomName('OscillatorNode.onended')
@DocsEditable()
@Experimental() // untriaged
@@ -1029,6 +1050,12 @@ class ScriptProcessorNode extends AudioNode native "ScriptProcessorNode,JavaScri
// To suppress missing implicit constructor warnings.
factory ScriptProcessorNode._() { throw new UnsupportedError("Not supported"); }
+ /**
+ * Static factory designed to expose `audioprocess` events to event
+ * handlers that are not necessarily instances of [ScriptProcessorNode].
+ *
+ * See [EventStreamProvider] for usage information.
+ */
@DomName('ScriptProcessorNode.audioprocessEvent')
@DocsEditable()
@Experimental() // untriaged
@@ -1038,7 +1065,8 @@ class ScriptProcessorNode extends AudioNode native "ScriptProcessorNode,JavaScri
@DocsEditable()
final int bufferSize;
- /**
+ /// Stream of `audioprocess` events handled by this [ScriptProcessorNode].
+/**
* Get a Stream that fires events when AudioProcessingEvents occur.
* This particular stream is special in that it only allows one listener to a
* given stream. Converting the returned Stream [asBroadcast] will likely ruin
« no previous file with comments | « sdk/lib/svg/dartium/svg_dartium.dart ('k') | sdk/lib/web_audio/dartium/web_audio_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698