Fix bug in caching of chunked transfer encoding in HTTP headers

Fix bug in caching of chunked transfer encoding in HTTP headers

R=ajohnsen@google.com
BUG=http://dartbug.com/20335

Committed: https://code.google.com/p/dart/source/detail?r=39116

[Anders Johnsen, 2014-08-11 12:39:56]

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:63: if (name == HttpHeaders.TRANSFER_ENCODING) {
This should hit the _add switch below, right?

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:80: }
Ditto.

[Søren Gjesse, 2014-08-11 14:20:49]

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:63: if (name == HttpHeaders.TRANSFER_ENCODING) {
On 2014/08/11 12:39:55, Anders Johnsen wrote:
> This should hit the _add switch below, right?

The problem is that the logic invoked by _add will check the current value of
_chunkedTransferEncoding to see if there was changes.

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:80: }
On 2014/08/11 12:39:56, Anders Johnsen wrote:
> Ditto.

This code never calls the _add code.

[Anders Johnsen, 2014-08-12 05:42:38]

lgtm

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:63: if (name == HttpHeaders.TRANSFER_ENCODING) {
On 2014/08/11 14:20:49, Søren Gjesse wrote:
> On 2014/08/11 12:39:55, Anders Johnsen wrote:
> > This should hit the _add switch below, right?
> 
> The problem is that the logic invoked by _add will check the current value of
> _chunkedTransferEncoding to see if there was changes.

I see. We should probably rewrite this logic at some point, to handle all of
add/set/remove.

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:80: }
On 2014/08/11 14:20:49, Søren Gjesse wrote:
> On 2014/08/11 12:39:56, Anders Johnsen wrote:
> > Ditto.
> 
> This code never calls the _add code.

Right!

[Søren Gjesse, 2014-08-12 06:38:33]

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/460653002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:63: if (name == HttpHeaders.TRANSFER_ENCODING) {
On 2014/08/12 05:42:38, Anders Johnsen wrote:
> On 2014/08/11 14:20:49, Søren Gjesse wrote:
> > On 2014/08/11 12:39:55, Anders Johnsen wrote:
> > > This should hit the _add switch below, right?
> > 
> > The problem is that the logic invoked by _add will check the current value
of
> > _chunkedTransferEncoding to see if there was changes.
> 
> I see. We should probably rewrite this logic at some point, to handle all of
> add/set/remove.

That we can absolutely agree on :-)

[Søren Gjesse, 2014-08-12 06:39:18]

Committed patchset #1 manually as 39116 (presubmit successful).