Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 460333003: do not suggest types when editing a name in a variable declaration (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

do not suggest types when editing a name in a variable declaration BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39195

Patch Set 1 #

Patch Set 2 : add type annotation #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -3 lines) Patch
M pkg/analysis_services/lib/src/completion/imported_type_computer.dart View 1 3 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_services/lib/src/completion/local_computer.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/completion/imported_type_computer_test.dart View 2 chunks +57 lines, -0 lines 0 comments Download
M pkg/analysis_services/test/completion/local_computer_test.dart View 4 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-08-12 15:17:19 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-12 16:41:16 UTC) #2
danrubel
6 years, 4 months ago (2014-08-13 13:11:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 39195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698