pkg/analysis_services/lib/src/completion/local_computer.dart - Issue 460333003: do not suggest types when editing a name in a variable declaration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/lib/src/completion/local_computer.dart

Issue 460333003: do not suggest types when editing a name in a variable declaration (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_services/lib/src/completion/imported_type_computer.dart ('k') | pkg/analysis_services/test/completion/imported_type_computer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/lib/src/completion/local_computer.dart

diff --git a/pkg/analysis_services/lib/src/completion/local_computer.dart b/pkg/analysis_services/lib/src/completion/local_computer.dart

index a9cd972fefa7da150e2098db60a97ed1a373932f..143c9a0dbcf270775d1dcd167ebd20a97eb516ef 100644

--- a/pkg/analysis_services/lib/src/completion/local_computer.dart

+++ b/pkg/analysis_services/lib/src/completion/local_computer.dart

@@ -178,4 +178,12 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {

visitNode(AstNode node) {

node.parent.accept(this);

}

+ visitVariableDeclaration(VariableDeclaration node) {

+ // Do not add suggestions if editing the name in a var declaration

+ SimpleIdentifier name = node.name;

+ if (name == null || name.offset < offset || offset > name.end) {

+ visitNode(node);

+ }

}