Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 459853003: remove duplicate suggestions (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix suggestion notification processing in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 1 2 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_services/lib/src/completion/local_computer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_services/test/completion/completion_test_util.dart View 1 chunk +12 lines, -3 lines 0 comments Download
M pkg/analysis_services/test/completion/local_computer_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-08-11 17:25:15 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-11 18:08:38 UTC) #2
danrubel
6 years, 4 months ago (2014-08-11 19:18:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 39100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698